[SYCL][libdevice][CMake][Trivial] Fix imf-fallback missing in NVPTX #16336
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Seems like the IMF fallback libraries are not collected in the merged libdevice for NVPTX and AMDGPU, because the name of the CMake property was wrong. I don't know why our testing does not catch this. I have seen this result in unresolved symbols earlier, but I have been sitting on this patch for a while and did not try with current trunk.
Maetveis
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
approved these changes
Dec 11, 2024
Maetveis
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
ping @intel/llvm-gatekeepers, please merge |
|
ping @intel/llvm-gatekeepers again, this should work now with me in the org. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Seems like the IMF fallback libraries are not collected in the merged libdevice for NVPTX and AMDGPU, because the name of the CMake property was wrong.
I don't know why our testing does not catch this. I have seen this result in unresolved symbols earlier, but I have been sitting on this patch for a while and did not try with current trunk.