[SYCL][Graphs] Fix whole graph update raw arg test #16377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update is only allowed if the kernel object is the same. Calling ext_oneapi_get_kernel is creating a new kernel object for each invocation, since the implementation doesn't cache kernels. The user should not assume the caching of kernels, so must use the same kernel objects each time for update.
EwanC
approved these changes
Dec 19, 2024
|
Ping @intel/llvm-gatekeepers this can be merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update is only allowed if the kernel object that the graph is being updated with is the same as the kernel that the graph was created with. Calling
ext_oneapi_get_kernelis creating a new SYCL kernel object for each invocation, since the implementation doesn't cache kernels for kernel bundles.The user should not assume the caching of kernels, so must use the same kernel objects each time for update.