[SYCL][E2E] Don't cover full combinations in vec_binary_scalar_order*
#16574
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, full coverage belongs to CTS, not to unit tests. Second, implementation is heavily templated and there isn't much differences potential for many intger types or vector sizes. This PR eliminates test cases that are unlikely to excercise the code not covered by the remaining ones. The purpose of this is to reduce the time these tests takes as they're very close to be a bottleneck on machines with lots of cores where total wall clock time is defined by the longest tests in the suite.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Jan 9, 2025
|
#12953 was previous attempt to deal with huge compile time by splitting the test into four (looks like it had been even worse before the split). |
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@steffenlarsen , please review post-commit. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, full coverage belongs to CTS, not to unit tests. Second, implementation is heavily templated and there isn't much differences potential for many intger types or vector sizes.
This PR eliminates test cases that are unlikely to excercise the code not covered by the remaining ones. The purpose of this is to reduce the time these tests takes as they're very close to be a bottleneck on machines with lots of cores where total wall clock time is defined by the longest tests in the suite.