[SYCL][RTC] Implement specified error behavior #17331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
approved these changes
Mar 6, 2025
jopperm
approved these changes
Mar 6, 2025
Contributor
jopperm
left a comment
jopperm
left a comment
There was a problem hiding this comment.
LGTM! You need to bump the counter in sycl/test/e2e_test_requirements/no_sycl_hpp_in_e2e_tests.cpp.
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Detect error scenarios in `sycl::ext::oneapi::build` and throw the errors specified in the extension. This handles two scenarios: - Calling build where one of the devices given in the list does not support the source language of the bundle. - Calling build where one of the devices given in the list does not belong to the context of the source bundle. Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
sommerlukas
force-pushed
the
rtc-report-device-errors
branch
from
f751a06 to
a5362da
Compare
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
sommerlukas
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
It seems the AMD test run was cancelled due to availability of the runner. As the |
adamfidel
pushed a commit
to reble/llvm
that referenced
this pull request
Mar 11, 2025
Detect error scenarios in `sycl::ext::oneapi::build` and throw the errors specified in the extension. This handles two scenarios: - Calling build where one of the devices given in the list does not support the source language of the bundle. - Calling build where one of the devices given in the list does not belong to the context of the source bundle. --------- Signed-off-by: Lukas Sommer <lukas.sommer@codeplay.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Detect error scenarios in
sycl::ext::oneapi::buildand throw the errors specified in the extension.This handles two scenarios: