Skip to content

Conversation

@KornevNikita
Copy link
Contributor

Due to incorrect REQUIRES these tests are never launched.

Due to incorrect REQUIRES these tests are never launched.
Compatible &= Dev.is_gpu();
Called = true;
}
if (sycl::is_compatible<KernelACC>(Dev)) {
Copy link
Contributor Author

@KornevNikita KornevNikita Mar 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this since there is no chance now to launch this on fpga.

@KornevNikita
Copy link
Contributor Author

@KseniyaTikhomirova take a look please

Copy link
Contributor

@KseniyaTikhomirova KseniyaTikhomirova left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

// There are no ROCm libs on win machines, so the compilation fails.

// RUN: %clangxx -fsycl -Xsycl-target-backend=amdgcn-amd-amdhsa --offload-arch=gfx906 -fsycl-targets=amdgcn-amd-amdhsa %S/Inputs/is_compatible_with_env.cpp -o %t.out
// RUN: %clangxx -fsycl -fsycl-targets=amdgcn-amd-amdhsa -Xsycl-target-backend=amdgcn-amd-amdhsa --offload-arch=gfx1030 %S/Inputs/is_compatible_with_env.cpp -o %t.out
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is there a necessity to specify --offload-arch? it is absent for cuda, maybe can be skipped here either.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I agree it may lead to a failure in the future if we change the hardware, but It looks like currently we don't specify the offload-arch automatically, need to extend the testing script. @intel/dpcpp-devops-reviewers am I missing something?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you could use %{hip_arch_opts}
see this bit,

if "target-amd" in build_targets:
hip_arch_opts = (
" -Xsycl-target-backend=amdgcn-amd-amdhsa --offload-arch={}".format(
test.config.amd_arch
)
)
sycl_target_opts += hip_arch_opts
substitutions.append(("%{hip_arch_opts}", hip_arch_opts))

Perhaps this could also be guarded by REQUIRES: any-target-is-amd instead of doing UNSUPPORTED: windows?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps you could use %{hip_arch_opts}

As I understand hip_arch_opts works only with target-amd, so it won't be substituted otherwise.

this could also be guarded by REQUIRES: any-target-is-amd

the intention of this test is to be launched on other than amd platform to check if the is_compatible<kernel>(dev) call returns false if the kernel was built for another device.

@KornevNikita
Copy link
Contributor Author

@intel/llvm-gatekeepers could you please merge?

@sarnex sarnex merged commit e1705eb into sycl Mar 26, 2025
22 checks passed
@KornevNikita KornevNikita deleted the upd-is-comp-e2e branch March 26, 2025 16:22
KornevNikita added a commit to KornevNikita/llvm that referenced this pull request Apr 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants