Skip to content

Conversation

@sarnex
Copy link
Contributor

@sarnex sarnex commented Mar 24, 2025

Has important fixes.

@sarnex sarnex temporarily deployed to WindowsCILock March 24, 2025 19:14 — with GitHub Actions Inactive
@sarnex sarnex marked this pull request as ready for review March 24, 2025 19:32
@sarnex sarnex requested review from a team and bader as code owners March 24, 2025 19:32
@sarnex sarnex temporarily deployed to WindowsCILock March 24, 2025 19:47 — with GitHub Actions Inactive
@sarnex sarnex temporarily deployed to WindowsCILock March 24, 2025 19:47 — with GitHub Actions Inactive
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bumping version without hash update is incorrect, we've tried that already in #17047 and it doesn't work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh, thanks

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

now, missing update in unified-runtime/third_party/requirements.txt...?

Signed-off-by: Sarnie, Nick <nick.sarnie@intel.com>
@sarnex
Copy link
Contributor Author

sarnex commented Mar 25, 2025

@lukaszstolarczuk fixed, my bad

Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx, LGTM

@sarnex sarnex merged commit 1fd657e into intel:sycl Mar 26, 2025
50 of 57 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants