Skip to content

[DeviceMSAN] Fix no "noundef" attribute in parameters and return value #17626

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Mar 26, 2025
Merged

[DeviceMSAN] Fix no "noundef" attribute in parameters and return value #17626

merged 3 commits into from
Mar 26, 2025

Conversation

@AllanZyne
Copy link
Contributor

@AllanZyne AllanZyne commented Mar 25, 2025 •
edited
Loading

  • Simplify "instrument_global_address_space.ll" test
  • Handle no "noundef" attribute in arguments and return value

@AllanZyne AllanZyne marked this pull request as ready for review March 25, 2025 08:27
@AllanZyne AllanZyne requested review from a team as code owners March 25, 2025 08:27
@AllanZyne AllanZyne changed the title [DeviceMSAN] Fix crash on return value [DeviceMSAN] Fix crash on no "noundef" attributes in parameters and return value Mar 25, 2025
@AllanZyne AllanZyne changed the title [DeviceMSAN] Fix crash on no "noundef" attributes in parameters and return value [DeviceMSAN] Fix no "noundef" attribute in parameters and return value Mar 25, 2025
@AllanZyne
Copy link
Contributor Author

AllanZyne commented Mar 25, 2025

Hi @intel/unified-runtime-reviewers, please review, thanks!

@AllanZyne
Copy link
Contributor Author

AllanZyne commented Mar 26, 2025

Failed test is tracked by #17075

@AllanZyne
Copy link
Contributor Author

AllanZyne commented Mar 26, 2025

@intel/llvm-gatekeepers, please merge. Thanks!

@aelovikov-intel aelovikov-intel merged commit ce5bfa8 into sycl Mar 26, 2025
26 of 31 checks passed
@AllanZyne AllanZyne deleted the review/yang/fix_msan_retval branch March 26, 2025 14:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@yingcong-wu yingcong-wu yingcong-wu approved these changes

+1 more reviewer

@aarongreig aarongreig aarongreig approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@AllanZyne @aarongreig @yingcong-wu @aelovikov-intel