Skip to content

Conversation

@jinge90
Copy link
Contributor

@jinge90 jinge90 commented Apr 22, 2025

No description provided.

@jinge90 jinge90 requested review from a team as code owners April 22, 2025 05:19
@jinge90 jinge90 requested a review from uditagarwal97 April 22, 2025 05:19
@yingcong-wu
Copy link
Contributor

Could you add e2e tests to tsan following the pattern in https://github.com/intel/llvm/tree/sycl/sycl/test-e2e/AddressSanitizer/aot ?

Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90 jinge90 requested a review from zhaomaosu April 22, 2025 06:30
Copy link
Contributor

@zhaomaosu zhaomaosu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Signed-off-by: jinge90 <ge.jin@intel.com>
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90
Copy link
Contributor Author

jinge90 commented Apr 22, 2025

Could you add e2e tests to tsan following the pattern in https://github.com/intel/llvm/tree/sycl/sycl/test-e2e/AddressSanitizer/aot ?

Done.
Thanks very much.

Signed-off-by: jinge90 <ge.jin@intel.com>
Signed-off-by: jinge90 <ge.jin@intel.com>
@jinge90
Copy link
Contributor Author

jinge90 commented Apr 25, 2025

Hi, @uditagarwal97
Could you help review this PR?
Thanks very much.

@jinge90
Copy link
Contributor Author

jinge90 commented Apr 28, 2025

Hi, @uditagarwal97
Kind ping~~~

Copy link
Contributor

@uditagarwal97 uditagarwal97 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes in libdevice/cmake/modules/SYCLLibdevice.cmake LGTM

@jinge90 jinge90 requested a review from a team April 29, 2025 01:30
@jinge90
Copy link
Contributor Author

jinge90 commented Apr 29, 2025

Hi, @intel/llvm-gatekeepers
Could you help merge this PR?
Thanks very much.

@steffenlarsen steffenlarsen merged commit 6249f30 into intel:sycl Apr 29, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants