[SYCL][Graph] Fix GCC 11.4 warning/issues in graph_memory_pool #18583
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Bensuo
commented
May 21, 2025
Bensuo
commented
- Rework code to avoid false positive uninitialized optional warning in GCC 11.4
- Uncomment early return code from tryReuseExistingAllocation
- Fix resetting last free node on temporary instead of value in MAllocations
- Also update codeowners for graphs to include graph_memory_pool.hpp/cpp
- Rework code to avoid false positive uninitialized optional warning in GCC 11.4 - Uncomment early return code from tryReuseExistingAllocation - Fix resetting last free node on temporary instead of value in MAllocations - Also update codeowners for graphs to include graph_memory_pool.hpp/cpp
Contributor
Author
|
@sarnex For visibility this should fix the issue you reported here: #18340 (comment) |
Contributor
Author
|
Jenkins failure looks spurious, so I've restarted the pipeline. |
EwanC
approved these changes
May 21, 2025
Contributor
|
Thank you @Bensuo! |
sarnex
approved these changes
May 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.