Skip to content

Conversation

@aelovikov-intel
Copy link
Contributor

Follow-up for #18477.

@aelovikov-intel aelovikov-intel requested a review from a team as a code owner May 21, 2025 19:58
@aelovikov-intel aelovikov-intel requested a review from againull May 21, 2025 19:58
@aelovikov-intel
Copy link
Contributor Author

Wasn't caught in pre-commit of #18477 because that task was failing due to infrastructure issues with Jenkins job at the moment.

@bader
Copy link
Contributor

bader commented May 21, 2025

Wasn't caught in pre-commit of #18477 because that task was failing due to infrastructure issues with Jenkins job at the moment.

The old gcc provides better diagnostics than the new one. 😮

@aelovikov-intel
Copy link
Contributor Author

Wasn't caught in pre-commit of #18477 because that task was failing due to infrastructure issues with Jenkins job at the moment.

The old gcc provides better diagnostics than the new one. 😮

  constexpr auto x = ...;
  if constexpr (c0) {
     // no-x-uses
  } else if constexpr (c1) {
    // use-x
  } else if constexpr (c2) {
    // another-use-x
  } else if constexpr (c3) {
    // no-x-uses
  }

I'd say attribute shouldn't be required and new gcc is correct not to emit the diagnostic.

@aelovikov-intel aelovikov-intel merged commit 44a1025 into intel:sycl May 21, 2025
22 of 24 checks passed
@aelovikov-intel aelovikov-intel deleted the fix-werror branch May 21, 2025 20:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants