[libclc][Native CPU] Add missing _CLC_DEF. #19367
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
libclc functions are meant to be declared with _CLC_DECL and defined with _CLC_DEF. A few Native CPU functions were defined without _CLC_DEF, so add the missing macro. This is effectively NFC, this applied to trivial functions that were being defined without always_inline but that would be inlined anyway.
coldav
approved these changes
Jul 9, 2025
frasercrmck
approved these changes
Jul 9, 2025
|
@intel/llvm-gatekeepers This looks ready to be merged, thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libclc functions are meant to be declared with _CLC_DECL and defined with _CLC_DEF. A few Native CPU functions were defined without _CLC_DEF, so add the missing macro.
This is effectively NFC, this applied to trivial functions that were being defined without always_inline but that would be inlined anyway.