Skip to content

Conversation

@bader
Copy link
Contributor

@bader bader commented Jul 16, 2025

Add sycl- prefix to the tests checking SYCL mode to make it easier to
find.

Changed file extension from .c to .cpp for libsycl-print-file-name.c
and print-internal-defines-for-sycl.c tests.

Add `sycl-` prefix to the tests checking SYCL mode to make it easier to
find.

Changed file extension from `.c` to `.cpp` for libsycl-print-file-name.c
and print-internal-defines-for-sycl.c tests.
@bader bader requested a review from a team as a code owner July 16, 2025 18:26
@bader bader temporarily deployed to WindowsCILock July 16, 2025 18:26 — with GitHub Actions Inactive
@bader
Copy link
Contributor Author

bader commented Jul 16, 2025

@uditagarwal97, what is going on with the Check for private emails used in PRs / validate_email (pull_request)? I'm pretty sure that I use corporate email for my contributions.

@bader bader temporarily deployed to WindowsCILock July 16, 2025 19:04 — with GitHub Actions Inactive
@bader bader temporarily deployed to WindowsCILock July 16, 2025 19:04 — with GitHub Actions Inactive
@uditagarwal97
Copy link
Contributor

@uditagarwal97, what is going on with the Check for private emails used in PRs / validate_email (pull_request)? I'm pretty sure that I use corporate email for my contributions.

That's weird. Let me debug it.

@bader
Copy link
Contributor Author

bader commented Jul 16, 2025

@uditagarwal97, what is going on with the Check for private emails used in PRs / validate_email (pull_request)? I'm pretty sure that I use corporate email for my contributions.

That's weird. Let me debug it.

Is it okay to merge with this check failing?

@uditagarwal97
Copy link
Contributor

@uditagarwal97, what is going on with the Check for private emails used in PRs / validate_email (pull_request)? I'm pretty sure that I use corporate email for my contributions.

That's weird. Let me debug it.

Is it okay to merge with this check failing?

Yes, please feel free to merge. It's a CI issue.

@bader bader merged commit 4f5d1e5 into intel:sycl Jul 16, 2025
24 of 26 checks passed
@bader bader deleted the test-name branch July 16, 2025 20:33
@asudarsa
Copy link
Contributor

Hi @bader and @mdtoguchi

Sorry. I just saw this. I am just wondering if it would have been cleaner to move all sycl related test to a sub-directory instead of renaming.

Thanks

@bader
Copy link
Contributor Author

bader commented Jul 22, 2025

Hi @bader and @mdtoguchi

Sorry. I just saw this. I am just wondering if it would have been cleaner to move all sycl related test to a sub-directory instead of renaming.

Thanks

@asudarsa, do you mean replace clang/test/Driver/sycl-<test-name>.cpp to clang/test/Driver/SYCL/<test-name>.cpp?
I'm okay if we run this through upstream first. Community uses prefixes for CUDA/HIP/OpenMP tests. It would be nice to have consistent scheme.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants