Skip to content

[CI] Clarify why KernelAndProgram/disable-caching change broke backward compatibility #19822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

[CI] Clarify why KernelAndProgram/disable-caching change broke backward compatibility #19822

wants to merge 3 commits into from

Conversation

@Alexandr-Konovalov
Copy link
Contributor

No description provided.

@Alexandr-Konovalov
Copy link
Contributor Author

Alexandr-Konovalov commented Aug 18, 2025 •
edited
Loading

Original PR hasn't change number of ur*retain/release calls, because the test hasn't cover the affected functionality. The test is extended in separate [SYCL] Extend test-e2e/KernelAndProgram/disable-caching.cpp #19821

@Alexandr-Konovalov Alexandr-Konovalov mentioned this pull request Aug 18, 2025
Merged
@Alexandr-Konovalov
Copy link
Contributor Author

Probably related fail: Reduction/reduction_internal_nd_range_1dim.cpp sporadically fails in pre-commit BMG&L0 #19767

@Alexandr-Konovalov Alexandr-Konovalov marked this pull request as ready for review August 19, 2025 09:56
@Alexandr-Konovalov
Copy link
Contributor Author

@gmlueck , @xtian-github , Could you please look at this?

xtian-github
xtian-github approved these changes Aug 20, 2025
View reviewed changes
Copy link

@xtian-github xtian-github left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. But, I will check with Sanitizer team to ensure ANL is ok.

@github-actions
Copy link
Contributor

github-actions bot commented Sep 2, 2025

@intel/llvm-gatekeepers please consider merging

1 similar comment
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

@intel/llvm-gatekeepers please consider merging

@KornevNikita
Copy link
Contributor

@Alexandr-Konovalov could you please update the branch

@KornevNikita
Copy link
Contributor

@xtian-github hi, any updates here?

@Alexandr-Konovalov
Copy link
Contributor Author

Failed Tests (1):
SYCL :: KernelCompiler/sycl_device_globals.cpp
Failure on CUDA is unrelated and already reported in #19965

@Alexandr-Konovalov
Copy link
Contributor Author

@Alexandr-Konovalov could you please update the branch

Sure, done.

@KornevNikita
Copy link
Contributor

@intel/llvm-gatekeepers I believe we can merge this one

@sarnex
Copy link
Contributor

sarnex commented Sep 8, 2025

can we add a description?

@Alexandr-Konovalov Alexandr-Konovalov changed the title [CI] Add clarification for KernelAndProgram/disable-caching change [CI] Clarify why KernelAndProgram/disable-caching change broke backward compatibility Sep 10, 2025
@Alexandr-Konovalov
Copy link
Contributor Author

can we add a description?

I tried to clarify the text.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gmlueck gmlueck gmlueck approved these changes

@xtian-github xtian-github xtian-github approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@Alexandr-Konovalov @KornevNikita @sarnex @gmlueck @xtian-github