Skip to content

[CI] Clarify why KernelAndProgram/disable-caching change broke backward compatibility #19822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: sycl
Choose a base branch
from
Open

[CI] Clarify why KernelAndProgram/disable-caching change broke backward compatibility #19822

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1810ca2
[CI] Add clarification for KernelAndProgram/disable-caching change
Alexandr-Konovalov Aug 18, 2025
0cd51a2
Merge branch 'sycl' into Alexandr-Konovalov/explain-disable-caching
Alexandr-Konovalov Aug 19, 2025
89e0c0c
Merge branch 'sycl' into Alexandr-Konovalov/explain-disable-caching
Alexandr-Konovalov Sep 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 5 additions & 9 deletions devops/compat_ci_exclude.sycl-rel-6_2
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,18 +28,14 @@ KernelCompiler/opencl.cpp
KernelCompiler/opencl_cache_eviction.cpp
KernelCompiler/opencl_queries.cpp

# https://github.com/intel/llvm/pull/18565 changed place and number of
# ur(Kernel|Program)(Retain|Release) calls and simultaneously changed the test.
# So the old test is incompatible with the new library and vice versa.
KernelAndProgram/disable-caching.cpp

# Likely OK, but need author to provide justification, get approval/confirmation
# from someone:

# https://github.com/intel/llvm/pull/18565
# This one should have probably be done in multiple PRs, first improving the
# test's CHECKs and then making an actual functional change.
#
# Based on the title, I'd expect to see reduction in number of ur*retain/release
# calls, but it only moves a few ur*release CHECKs, so I'll let the author
# update this explanation.
KernelAndProgram/disable-caching.cpp

# https://github.com/intel/llvm/pull/18253 broke at least some of the pre-built
# E2E binaries, but do we really need to provide backward compatibility for
# binaries built with sanitizers?
Expand Down
Loading