Skip to content

[UR][OpenCL] Remove redundant library loading on Windows #19900

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 2, 2025
Merged

[UR][OpenCL] Remove redundant library loading on Windows #19900

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions unified-runtime/source/adapters/opencl/adapter.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,17 +26,15 @@ static ur_adapter_handle_t liveAdapter = nullptr;
ur_adapter_handle_t_::ur_adapter_handle_t_() : handle_base() {
#ifdef _MSC_VER

// Loading OpenCL.dll increments the libraries internal reference count.
auto handle = LoadLibraryA("OpenCL.dll");
// Retrieving handle of an already linked OpenCL.dll library doesn't increase
// the reference count.
auto handle = GetModuleHandleA("OpenCL.dll");
assert(handle);

#define CL_CORE_FUNCTION(FUNC) \
FUNC = reinterpret_cast<decltype(::FUNC) *>(GetProcAddress(handle, #FUNC));
#include "core_functions.def"
#undef CL_CORE_FUNCTION

// So we can safely decrement it here wihtout actually unloading OpenCL.dll.
FreeLibrary(handle);

#else // _MSC_VER

// Use the default shared object search order (RTLD_DEFAULT) since the
Expand Down
Loading