-
Notifications
You must be signed in to change notification settings - Fork 796
[SYCL RTC] Specify --target when compiling resource.cpp
#20013
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The CI errors are not related to this PR and show up in other PRs as well. I can rebase and rerun when things are stable again. |
resource.cpp
resource.cpp--target when calling clang for resource.cpp
--target when calling clang for resource.cpp--target when compiling resource.cpp
aelovikov-intel
approved these changes
Sep 9, 2025
${clang_exe} may not default to the same target as ${CMAKE_CXX_COMPILER}.
This change is not sufficient to fix all cases, as it does not ensure
compatibility with target flags in ${CMAKE_CXX_FLAGS}, but handles the
most common cases when cross compiling.
b1ebaf1 to
b632418
Compare
aelovikov-intel
approved these changes
Sep 9, 2025
jopperm
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
${clang_exe}may not default to the same target as${CMAKE_CXX_COMPILER}.This change is not sufficient to fix all cases, as it does not ensure compatibility with target flags in
${CMAKE_CXX_FLAGS}, but handles the most common cases when cross compiling.