Skip to content

Conversation

@hvdijk
Copy link
Contributor

@hvdijk hvdijk commented Sep 9, 2025

${clang_exe} may not default to the same target as ${CMAKE_CXX_COMPILER}.

This change is not sufficient to fix all cases, as it does not ensure compatibility with target flags in ${CMAKE_CXX_FLAGS}, but handles the most common cases when cross compiling.

@hvdijk hvdijk marked this pull request as ready for review September 9, 2025 11:31
@hvdijk hvdijk requested a review from a team as a code owner September 9, 2025 11:31
@hvdijk
Copy link
Contributor Author

hvdijk commented Sep 9, 2025

The CI errors are not related to this PR and show up in other PRs as well. I can rebase and rerun when things are stable again.

@aelovikov-intel aelovikov-intel changed the title Specify --target when calling clang. [SYCL RTC] Specify --target when calling clang for resource.cpp Sep 9, 2025
@aelovikov-intel aelovikov-intel changed the title [SYCL RTC] Specify --target when calling clang for resource.cpp [SYCL RTC] Specify --target when calling clang for resource.cpp Sep 9, 2025
@aelovikov-intel aelovikov-intel changed the title [SYCL RTC] Specify --target when calling clang for resource.cpp [SYCL RTC] Specify --target when compiling resource.cpp Sep 9, 2025
${clang_exe} may not default to the same target as ${CMAKE_CXX_COMPILER}.

This change is not sufficient to fix all cases, as it does not ensure
compatibility with target flags in ${CMAKE_CXX_FLAGS}, but handles the
most common cases when cross compiling.
@aelovikov-intel aelovikov-intel merged commit ae97908 into intel:sycl Sep 9, 2025
27 of 28 checks passed
@hvdijk hvdijk deleted the specify-target branch September 9, 2025 23:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants