Skip to content

[SYCL RTC] Correctly handle /MT//MD on Windows #20027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 9, 2025
Merged

[SYCL RTC] Correctly handle /MT//MD on Windows #20027

merged 2 commits into from
Sep 9, 2025

Conversation

@aelovikov-intel
Copy link
Contributor

@aelovikov-intel aelovikov-intel commented Sep 9, 2025 •
edited
Loading

We use /MT downstream where #19924 has caused some issues. This fixes that.

aelovikov-intel
aelovikov-intel commented Sep 9, 2025
View reviewed changes
@aelovikov-intel aelovikov-intel marked this pull request as ready for review September 9, 2025 20:32
@aelovikov-intel aelovikov-intel requested a review from a team as a code owner September 9, 2025 20:32
@aelovikov-intel
Copy link
Contributor Author

aelovikov-intel commented Sep 9, 2025

@sarnex 's review for the CMake changes should be enough. @intel/dpcpp-kernel-fusion-reviewers please take a look post-commit.

@aelovikov-intel aelovikov-intel merged commit b239891 into intel:sycl Sep 9, 2025
27 of 28 checks passed
@aelovikov-intel aelovikov-intel deleted the sycl-rtc-win-mt branch September 9, 2025 21:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarnex sarnex sarnex approved these changes

@cperkinsintel cperkinsintel Awaiting requested review from cperkinsintel cperkinsintel is a code owner

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@aelovikov-intel @sarnex @jsji