[CI] Use cosign to sign nightly builds #20034
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Enable artifact signing with sigstore/cosign in CI. This ensures that the builds were built exactly by the sycl-nightly workflow.
aelovikov-intel
approved these changes
Sep 10, 2025
Contributor
aelovikov-intel
left a comment
aelovikov-intel
left a comment
There was a problem hiding this comment.
Not an expert, so feel free to gather extra feedback, but I don't see anything bad here.
sarnex
reviewed
Sep 10, 2025
| runs-on: ubuntu-latest | ||
| permissions: | ||
| contents: write | ||
| id-token: write |
Contributor
There was a problem hiding this comment.
any idea why we need write for this?
Contributor
Author
There was a problem hiding this comment.
https://docs.sigstore.dev/quickstart/quickstart-ci/#signing-files-using-your-ci-system says:
'id-token' needs write permission to retrieve the OIDC token, which is required for authentication.
Contributor
There was a problem hiding this comment.
comment makes no sense to me, retrieve seems like a read operation, but seems their problem not ours
Contributor
Author
There was a problem hiding this comment.
I can try to remove this just in case
sarnex
approved these changes
Sep 10, 2025
Contributor
sarnex
left a comment
sarnex
left a comment
There was a problem hiding this comment.
cant provide in depth technical review but no flags
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable artifact signing with sigstore/cosign in CI. This ensures that the builds were built exactly by the sycl-nightly workflow.