-
Notifications
You must be signed in to change notification settings - Fork 796
[E2E] Enable end-to-end tests supported by the SPIR-V backend #20418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
dba5e6a to
1cb45c5
Compare
AlexeySachkov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Bindless images LGTM
1cb45c5 to
a6a9216
Compare
sarnex
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm just a nit
| name: macOS | ||
| if: github.repository == 'intel/llvm' | ||
| uses: ./.github/workflows/sycl-macos-build-and-test.yml | ||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: remove newline
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for pointing this out! This line is added to enable post-commit testing and will be removed afterward.
| # TRACKER: https://github.com/intel/llvm/issues/16184 | ||
| config.unsupported_features += ['gpu-intel-gen12', 'gpu-intel-dg2'] | ||
|
|
||
| # CMPLRLLVM-64052 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I do see more disabled tests in repo:
./sycl/test-e2e/AddressSanitizer/lit.local.cfg:config.unsupported_features += ['spirv-backend']
enabled back ./sycl/test-e2e/Basic/image/lit.local.cfg:config.unsupported_features += ['spirv-backend', 'target-amd']
enabled back ./sycl/test-e2e/Sampler/lit.local.cfg:config.unsupported_features += ['spirv-backend', 'target-amd']
./sycl/test-e2e/MemorySanitizer/lit.local.cfg:config.unsupported_features += ['spirv-backend']
./sycl/test-e2e/ESIMD/lit.local.cfg:config.unsupported_features += ['spirv-backend']
enabled back ./sycl/test-e2e/bindless_images/lit.local.cfg:config.unsupported_features += ['spirv-backend']
./sycl/test-e2e/Matrix/lit.local.cfg:config.unsupported_features += ['spirv-backend']
enabled back ./sycl/test-e2e/ThreadSanitizer/lit.local.cfg:config.unsupported_features += ['spirv-backend']
./sycl/test-e2e/USM/memops2d/lit.local.cfg:config.unsupported_features += ['spirv-backend']
./sycl/test-e2e/InvokeSimd/lit.local.cfg:config.unsupported_features += ['spirv-backend']
memory sanitizer test disabling refers to the same Jira as here:
https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/MemorySanitizer/lit.local.cfg#L18
Just want to ensure that other tests are intentionally not enabled back. Could you please confirm?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for pointing this out! You can find more details about which tests were enabled and the Jira tickets that resolved them in Jira CMPLRLLVM-70031. The tests that remain disabled are intentional, as they are still failing and need to be resolved by the SPIR-V Backend team.
|
Could you please provide a better description in the issues you created and referenced in tests? It will be helpful to keep log or at least a part of it that shows how exactly it fails. I doubt those issues will be investigated right after creation and without this data it will be hard to understand what that issues are about. |
0f9e08b to
ebef10f
Compare
|
All pre-commit and post-commit CI tests have passed successfully (the failing tests in CI are unrelated to this PR's changes). Post-commit CI results are available in the commit history. @intel/dpcpp-sanitizers-review Could you please help review this PR? Thank you! |
|
All CI tests have passed (I don't think the current CI failure is related to this PR's changes) and the PR have been approved. @intel/llvm-gatekeepers could you please help merge this PR? |
|
Failure in |
This PR re-enables SYCL end-to-end tests previously marked as XFAIL or UNSUPPORTED on the SPIR-V backend, as they now pass. For tests that are still failing, new issues have been created in llvm-project and added as XFAIL-TRACKER.
This is the second PR for re-enabling SYCL end-to-end because the previous one is reverted due to post-commit failure.