Skip to content

Conversation

@YixingZhang007
Copy link
Contributor

@YixingZhang007 YixingZhang007 commented Oct 21, 2025

This PR re-enables SYCL end-to-end tests previously marked as XFAIL or UNSUPPORTED on the SPIR-V backend, as they now pass. For tests that are still failing, new issues have been created in llvm-project and added as XFAIL-TRACKER.

This is the second PR for re-enabling SYCL end-to-end because the previous one is reverted due to post-commit failure.

@YixingZhang007 YixingZhang007 requested review from a team as code owners October 21, 2025 14:05
@YixingZhang007 YixingZhang007 changed the title Enable end-to-end tests supported by the SPIR-V backend [E2E] Enable end-to-end tests supported by the SPIR-V backend Oct 21, 2025
@YixingZhang007 YixingZhang007 force-pushed the yixingzh/enable_spirv_test branch from dba5e6a to 1cb45c5 Compare October 22, 2025 14:21
Copy link
Contributor

@AlexeySachkov AlexeySachkov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bindless images LGTM

Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm just a nit

name: macOS
if: github.repository == 'intel/llvm'
uses: ./.github/workflows/sycl-macos-build-and-test.yml

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: remove newline

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for pointing this out! This line is added to enable post-commit testing and will be removed afterward.

# TRACKER: https://github.com/intel/llvm/issues/16184
config.unsupported_features += ['gpu-intel-gen12', 'gpu-intel-dg2']

# CMPLRLLVM-64052
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do see more disabled tests in repo:


./sycl/test-e2e/AddressSanitizer/lit.local.cfg:config.unsupported_features += ['spirv-backend']
enabled back ./sycl/test-e2e/Basic/image/lit.local.cfg:config.unsupported_features += ['spirv-backend', 'target-amd']
enabled back ./sycl/test-e2e/Sampler/lit.local.cfg:config.unsupported_features += ['spirv-backend', 'target-amd']
./sycl/test-e2e/MemorySanitizer/lit.local.cfg:config.unsupported_features += ['spirv-backend']
./sycl/test-e2e/ESIMD/lit.local.cfg:config.unsupported_features += ['spirv-backend']
enabled back ./sycl/test-e2e/bindless_images/lit.local.cfg:config.unsupported_features += ['spirv-backend']
./sycl/test-e2e/Matrix/lit.local.cfg:config.unsupported_features += ['spirv-backend']
enabled back ./sycl/test-e2e/ThreadSanitizer/lit.local.cfg:config.unsupported_features += ['spirv-backend']
./sycl/test-e2e/USM/memops2d/lit.local.cfg:config.unsupported_features += ['spirv-backend']
./sycl/test-e2e/InvokeSimd/lit.local.cfg:config.unsupported_features += ['spirv-backend']

memory sanitizer test disabling refers to the same Jira as here:
https://github.com/intel/llvm/blob/sycl/sycl/test-e2e/MemorySanitizer/lit.local.cfg#L18

Just want to ensure that other tests are intentionally not enabled back. Could you please confirm?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for pointing this out! You can find more details about which tests were enabled and the Jira tickets that resolved them in Jira CMPLRLLVM-70031. The tests that remain disabled are intentional, as they are still failing and need to be resolved by the SPIR-V Backend team.

@KseniyaTikhomirova
Copy link
Contributor

Could you please provide a better description in the issues you created and referenced in tests? It will be helpful to keep log or at least a part of it that shows how exactly it fails. I doubt those issues will be investigated right after creation and without this data it will be hard to understand what that issues are about.
Thank you.

@YixingZhang007
Copy link
Contributor Author

YixingZhang007 commented Oct 27, 2025

All pre-commit and post-commit CI tests have passed successfully (the failing tests in CI are unrelated to this PR's changes). Post-commit CI results are available in the commit history.

@intel/dpcpp-sanitizers-review Could you please help review this PR? Thank you!

@YixingZhang007
Copy link
Contributor Author

All CI tests have passed (I don't think the current CI failure is related to this PR's changes) and the PR have been approved. @intel/llvm-gatekeepers could you please help merge this PR?

@uditagarwal97
Copy link
Contributor

Failure in KernelCompiler/sycl_device_globals.cpp on CUDA is reported in #20408

@uditagarwal97 uditagarwal97 merged commit bdf2e56 into sycl Oct 28, 2025
28 of 29 checks passed
@uditagarwal97 uditagarwal97 deleted the yixingzh/enable_spirv_test branch October 28, 2025 02:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants