[NFC][LLVM] Remove duplication for zstd cmake config #20444
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I suspect the duplication happened because I first made the change to intel/llvm and then upstream, which brought the change back again to intel/llvm
uditagarwal97
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
uditagarwal97
commented
Oct 23, 2025
Comment on lines
-212
to
-222
| # If LLVM_USE_STATIC_ZSTD is specified, make sure we enable zstd only if static | ||
| # libraries are found. | ||
| if(LLVM_USE_STATIC_ZSTD AND NOT TARGET zstd::libzstd_static) | ||
| # Fail if LLVM_ENABLE_ZSTD is FORCE_ON. | ||
| if(LLVM_ENABLE_ZSTD STREQUAL FORCE_ON) | ||
| message(FATAL_ERROR "Failed to find static zstd libraries, but LLVM_USE_STATIC_ZSTD=ON and LLVM_ENABLE_ZSTD=FORCE_ON.") | ||
| endif() | ||
| set(LLVM_ENABLE_ZSTD OFF) | ||
| else() | ||
| set(LLVM_ENABLE_ZSTD ${zstd_FOUND}) | ||
| endif() |
Contributor
Author
There was a problem hiding this comment.
This code block is duplicate of the block above. Ideally, it should have been removed in the pulldown commit: 8cb519c
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
approved these changes
Oct 23, 2025
Contributor
Author
|
SYCL precommit failures are unrelated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I suspect the duplication happened because I first made the change to intel/llvm and then upstream, which brought the change back again to intel/llvm