[SYCL][E2E] dynamic_compress.cpp fix #20446
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Comment on lines
6
to
7
| // XFAIL: (windows && run-mode) || target-native_cpu | ||
| // XFAIL-TRACKER: https://github.com/intel/llvm/issues/20397 |
Contributor
There was a problem hiding this comment.
Suggested change
| // XFAIL: target-native_cpu | |
| // XFAIL-TRACKER: https://github.com/intel/llvm/issues/20397 |
|
|
||
| // RUN: rm -rf %t.dir; mkdir -p %t.dir | ||
| // RUN: %clangxx %{dynamic_lib_options} %S/Inputs/d.cpp \ | ||
| // RUN: -o %t.dir/libdevicecompress_d.%{dynamic_lib_suffix} |
Contributor
There was a problem hiding this comment.
I'm wondering if we should just remove %t.dir and keep all dependencies (_d,_c,_b,_a libraries) in the same directory as test executable.
Contributor
Author
There was a problem hiding this comment.
I'm not sure. Don't we need to use some form of %t so that it can be targeted?
We could have the app output into %t.dir as well, couldn't we?
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
…untime to inclue %t.dir on Win
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Signed-off-by: Chris Perkins <chris.perkins@intel.com>
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
cperkinsintel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Oct 24, 2025
Contributor
|
@intel/llvm-gatekeepers please consider merging |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test started failing after llvm/llvm-project@7ff6973f1
We used to just build the libs in the same directory as the app, but now they are in a subdirectory. Picking up ALL the lib files like we do on Linux should work.