[SYCL][NFC] Drop confusing std::moves
#20483
Open
+9
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to intel#20455 - there is a bunch of places where we call `std::move(const obj &)`, but target classes do not provide `obj(const &&)` move constructors, falling back to regular `obj(const &)` copy constructor, thus making the `std::move` useless and confusing. This should also help clean up the Coverity scan (https://scan.coverity.com/projects/intel-llvm?tab=overview), see CIDs `535398`, `535480`, `535420` and `535554`. By some reason Coverity thinks that we are using a moved object, whilst in fact no moves were performed, only copies.
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
uditagarwal97
approved these changes
Oct 27, 2025
AlexeySachkov
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
AlexeySachkov
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is similar to #20455 - there is a bunch of places where we call
std::move(const obj &), but target classes do not provideobj(const &&)move constructors, falling back to regularobj(const &)copy constructor, thus making thestd::moveuseless and confusing.This should also help clean up the Coverity scan
(https://scan.coverity.com/projects/intel-llvm?tab=overview), see CIDs
535398,535480,535420and535554. By some reason Coverity thinks that we are using a moved object, whilst in fact no moves were performed, only copies.