Skip to content

[SYCL][NFC] Drop confusing std::moves #20483

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: sycl
Choose a base branch
from
+9 −9
Open

[SYCL][NFC] Drop confusing std::moves #20483

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 7 additions & 7 deletions sycl/source/detail/device_image_impl.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -296,7 +296,7 @@ class device_image_impl
KernelNameSetT &&KernelNames,
KernelNameToArgMaskMap &&EliminatedKernelArgMasks,
std::unique_ptr<DynRTDeviceBinaryImage> &&MergedImageStorage, private_tag)
: MBinImage(BinImage), MContext(std::move(Context)),
: MBinImage(BinImage), MContext(Context),
MDevices(Devices.to<std::vector<device_impl *>>()), MState(State),
MProgram(std::move(Program)), MKernelIDs(std::move(KernelIDs)),
MKernelNames{std::move(KernelNames)},
Expand All @@ -315,7 +315,7 @@ class device_image_impl
MangledKernelNameMapT &&MangledKernelNames, std::string &&Prefix,
std::shared_ptr<ManagedDeviceGlobalsRegistry> &&DeviceGlobalRegistry,
private_tag)
: MBinImage(BinImage), MContext(std::move(Context)),
: MBinImage(BinImage), MContext(Context),
MDevices(Devices.to<std::vector<device_impl *>>()), MState(State),
MKernelIDs(std::move(KernelIDs)), MKernelNames{std::move(KernelNames)},
MSpecConstsDefValBlob(getSpecConstsDefValBlob()),
Expand All @@ -329,7 +329,7 @@ class device_image_impl
device_image_impl(const std::string &Src, context Context,
devices_range Devices, syclex::source_language Lang,
include_pairs_t &&IncludePairsVec, private_tag)
: MBinImage(Src), MContext(std::move(Context)),
: MBinImage(Src), MContext(Context),
MDevices(Devices.to<std::vector<device_impl *>>()),
MState(bundle_state::ext_oneapi_source),
MSpecConstsDefValBlob(getSpecConstsDefValBlob()),
Expand All @@ -342,7 +342,7 @@ class device_image_impl
device_image_impl(const std::vector<std::byte> &Bytes, const context &Context,
devices_range Devices, syclex::source_language Lang,
private_tag)
: MBinImage(Bytes), MContext(std::move(Context)),
: MBinImage(Bytes), MContext(Context),
MDevices(Devices.to<std::vector<device_impl *>>()),
MState(bundle_state::ext_oneapi_source),
MSpecConstsDefValBlob(getSpecConstsDefValBlob()),
Expand All @@ -356,9 +356,9 @@ class device_image_impl
syclex::source_language Lang, KernelNameSetT &&KernelNames,
private_tag)
: MBinImage(static_cast<const RTDeviceBinaryImage *>(nullptr)),
MContext(std::move(Context)),
MDevices(Devices.to<std::vector<device_impl *>>()), MState(State),
MProgram(std::move(Program)), MKernelNames{std::move(KernelNames)},
MContext(Context), MDevices(Devices.to<std::vector<device_impl *>>()),
MState(State), MProgram(std::move(Program)),
MKernelNames{std::move(KernelNames)},
MSpecConstsDefValBlob(getSpecConstsDefValBlob()),
MOrigins(ImageOriginKernelCompiler),
MRTCBinInfo(KernelCompilerBinaryInfo{Lang}) {}
Expand Down
4 changes: 2 additions & 2 deletions sycl/source/detail/scheduler/commands.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1511,8 +1511,8 @@ MemCpyCommand::MemCpyCommand(const Requirement &SrcReq,
queue_impl *SrcQueue, queue_impl *DstQueue)
: Command(CommandType::COPY_MEMORY, DstQueue),
MSrcQueue(SrcQueue ? SrcQueue->shared_from_this() : nullptr),
MSrcReq(std::move(SrcReq)), MSrcAllocaCmd(SrcAllocaCmd),
MDstReq(std::move(DstReq)), MDstAllocaCmd(DstAllocaCmd) {
MSrcReq(SrcReq), MSrcAllocaCmd(SrcAllocaCmd), MDstReq(DstReq),
MDstAllocaCmd(DstAllocaCmd) {
if (MSrcQueue) {
MEvent->setContextImpl(MSrcQueue->getContextImpl());
}
Expand Down
Loading