[SYCL] Enable only selected SPIR-V extensions for SPIR-V backend. #20489
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maarquitos14
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
MrSidims
approved these changes
Oct 28, 2025
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
maarquitos14
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
maarquitos14
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers Can we get this merged? Thanks! |
|
@maarquitos14 Seeing many postcommit fails when building E2E tests. Can you take a look? https://github.com/intel/llvm/actions/runs/18885080359/job/53898211124 If you can't fix quickly lets revert. |
| // compilation" error | ||
| // - handle --spirv-ext=+<extension> and --spirv-ext=-<extension> options | ||
|
|
||
| // Disable all the extensions by default |
There was a problem hiding this comment.
Could you please update the comment to add why we are disabling all the SPIR-V backend extensions to give some additional context?
sarnex
added a commit
that referenced
this pull request
Oct 28, 2025
|
@maarquitos14 Reverted this change, please fix CI failures and make a new PR, thanks |
maarquitos14
added a commit
to maarquitos14/llvm
that referenced
this pull request
Oct 29, 2025
…tel#20489) SPIR-V backend supports some extensions that our driver doesn't support yet (e.g. SPV_KHR_float_controls2), resulting in errors. This patch stops enabling all the SPIR-V backend supported extensions, and instead enables only a list of selected extensions. The list contains the intersection of extensions enabled for llvm-spirv with the extensions supported by the SPIR-V backend.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SPIR-V backend supports some extensions that our driver doesn't support yet (e.g. SPV_KHR_float_controls2), resulting in errors. This patch stops enabling all the SPIR-V backend supported extensions, and instead enables only a list of selected extensions. The list contains the intersection of extensions enabled for llvm-spirv with the extensions supported by the SPIR-V backend.