Skip to content

Conversation

@uditagarwal97
Copy link
Contributor

No description provided.

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the no-handler (direct) kernel submission path to support kernel properties. Previously, kernel properties required handler-based submission, but now they can be used with the more efficient direct submission path for single_task, parallel_for, and nd_launch operations.

  • Added kernel property support to direct submission functions
  • Updated function signatures to accept and propagate kernel properties
  • Removed conditional checks that forced handler-based submission when properties were present

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
sycl/test/abi/sycl_symbols_linux.dump Updated ABI symbols to reflect new function signatures with kernel property parameters
sycl/source/queue.cpp Added Props parameter to template instantiations and forwarding calls
sycl/source/detail/queue_impl.hpp Updated method signatures to accept kernel property holder parameter
sycl/source/detail/queue_impl.cpp Implemented property validation and extraction in the direct submission path
sycl/include/sycl/queue.hpp Refactored function signatures to support properties, merged kernel and launch properties, and removed property-based submission restrictions
sycl/include/sycl/khr/free_function_commands.hpp Removed property checks from conditional compilation and updated function calls
sycl/include/sycl/ext/oneapi/experimental/enqueue_functions.hpp Enabled property support for nd_launch with launch_config and updated other enqueue functions

@uditagarwal97 uditagarwal97 merged commit d5d8b19 into sycl Nov 3, 2025
43 of 45 checks passed
@uditagarwal97 uditagarwal97 deleted the private/udit/no_handler_prop branch November 3, 2025 18:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants