-
Notifications
You must be signed in to change notification settings - Fork 794
[UR][CI] Update to v1.25.2 L0 with fixed L0 api symbols #20537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: sycl
Are you sure you want to change the base?
Conversation
22512b8 to
4e78a1c
Compare
4e78a1c to
9a664ee
Compare
9a664ee to
84e351f
Compare
84e351f to
1f4dc3d
Compare
1f4dc3d to
6817bf4
Compare
6817bf4 to
42c4cf8
Compare
42c4cf8 to
16f7816
Compare
- Due to symbol conflicts in the L0 gpu driver, zeCommandListAppendLaunchKernelWithArguments can only be used from the spec definition and the driver exp cannot be used as of the update to v1.14 supported symbols. Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
16f7816 to
e777ffb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake/devops lgtm
| zeCommandListAppendLaunchKernelWithArguments; | ||
| ZeCommandListAppendLaunchKernelWithArgumentsExt.Supported = true; | ||
| } else { | ||
| ZeCommandListAppendLaunchKernelWithArgumentsExt.Supported = false; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@nrspruit Why cannot zeCommandListAppendLaunchKernelWithArgumentsFunctionPtr be read using zeDriverGetExtensionFunctionAddress() in case of older drivers as it was before?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately, because the driver exp version of zeCommandListAppendLaunchKernelWithArguments is named the same as the spec version, the driver was reporting the loader's symbol instead of its own once v1.14 L0 supported loader is loaded into the application, thus returning the "unsupported" version of the api in that driver. So, the existence of the new loader in the system exposes the bug in the driver. The bug in the driver has been fixed, but by the time the fix for this issue will be in a driver in the CI, then the driver EXP function will no longer be supported and is replaced by the L0 spec function, which is what I changed this to use.
Therefore, we cannot report support for that api in the UR V2 adapter until one has a new enough driver with the fix:
intel/compute-runtime@c92ab7c
Which will also include the support for the L0 spec api.
No description provided.