Skip to content

Conversation

@nrspruit
Copy link
Contributor

@nrspruit nrspruit commented Nov 3, 2025

No description provided.

@nrspruit nrspruit changed the title [test] Update to v1.25.2 L0 [UR][CI] Update to v1.25.2 L0 with fixed L0 api symbols Nov 3, 2025
- Due to symbol conflicts in the L0 gpu driver, zeCommandListAppendLaunchKernelWithArguments
  can only be used from the spec definition and the driver exp cannot be
used as of the update to v1.14 supported symbols.

Signed-off-by: Neil R. Spruit <neil.r.spruit@intel.com>
@nrspruit nrspruit marked this pull request as ready for review November 3, 2025 21:33
@nrspruit nrspruit requested review from a team as code owners November 3, 2025 21:33
Copy link
Contributor

@sarnex sarnex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cmake/devops lgtm

zeCommandListAppendLaunchKernelWithArguments;
ZeCommandListAppendLaunchKernelWithArgumentsExt.Supported = true;
} else {
ZeCommandListAppendLaunchKernelWithArgumentsExt.Supported = false;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nrspruit Why cannot zeCommandListAppendLaunchKernelWithArgumentsFunctionPtr be read using zeDriverGetExtensionFunctionAddress() in case of older drivers as it was before?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately, because the driver exp version of zeCommandListAppendLaunchKernelWithArguments is named the same as the spec version, the driver was reporting the loader's symbol instead of its own once v1.14 L0 supported loader is loaded into the application, thus returning the "unsupported" version of the api in that driver. So, the existence of the new loader in the system exposes the bug in the driver. The bug in the driver has been fixed, but by the time the fix for this issue will be in a driver in the CI, then the driver EXP function will no longer be supported and is replaced by the L0 spec function, which is what I changed this to use.

Therefore, we cannot report support for that api in the UR V2 adapter until one has a new enough driver with the fix:
intel/compute-runtime@c92ab7c

Which will also include the support for the L0 spec api.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants