[SYCLLowerIR] Fix a hierarchical parallelism bug #20550
Open
+26
−7
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
lbushi25
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
lbushi25
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YuriPlyakhin
approved these changes
Nov 4, 2025
Contributor
|
Is it possible to extract LLVM snippet from the E2E test? Bypassing LIT test modification significantly complicates later upstreaming. |
cperkinsintel
approved these changes
Nov 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is a bug in my earlier PR #20484. When encountering an indirect call to a
parallel_for_work_itemfunction, the range of instructions that will be subjected to the lowering pass must be closed, whereas the current code simply skips over this instruction as its iterating the instructions of the basic block which effectively keeps extending the range. There is an E2E test that reflects this bug where it used to hang before this fix but so far I'm not aware of an LLVM-IR snippet of code that triggers it so for the moment, I'm just adding a SYCL-level test.