-
Notifications
You must be signed in to change notification settings - Fork 796
[SYCL][NewOffloadModel] Enforce default SYCL device library to use old offloading model #20569
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[SYCL][NewOffloadModel] Enforce default SYCL device library to use old offloading model #20569
Conversation
… built with --no-new-offload-model flag
…hanges will be reverted after running CI
|
The modifications to set the new offloading model as default in this PR were directly copied from (#15121). These changes will be removed once CI confirms there are no regressions. |
|
I do not think the current CI test failure is caused by the changes from this PR. I have also run the SYCL E2E tests with the new offloading model enabled as default together with my changes (the results can also be found at (https://github.com/intel/llvm/actions/runs/19120134686/job/54640222730; this is the CI from before removing the new offloading model changes from this PR). I haven't seen any regression, and the two tests |
|
I think this PR is waiting for review from @intel/llvm-reviewers-runtime. Thank you :) |
|
My review should be fine for runtime |
This pull request enforces the default SYCL device library to always be built with the old offloading model, regardless of which offloading model (new or old) is set as the default. This is implemented by adding
--no-offload-new-driverto thedevice_compile_optsinlibdevice/cmake/modules/SYCLLibdevice.cmake.The motivation for this change is to address test failures in
Config/kernel_from_file.cppandSeparateCompile/test.cppthat occur when the new offloading model is enabled as the default. These failures happen becauseclang-offload-bundlerdoes not support extracting libraries built with the new offloading model.