-
Notifications
You must be signed in to change notification settings - Fork 801
[SYCL] Fix memory access inside deallocated region when using default accessor #20632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
steffenlarsen
merged 14 commits into
intel:sycl
from
lbushi25:fix_memory_bug_default_accessor
Nov 25, 2025
Merged
[SYCL] Fix memory access inside deallocated region when using default accessor #20632
steffenlarsen
merged 14 commits into
intel:sycl
from
lbushi25:fix_memory_bug_default_accessor
Nov 25, 2025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 34a11ca.
dyniols
approved these changes
Nov 19, 2025
Contributor
Author
|
@intel/llvm-reviewers-runtime ping for review |
steffenlarsen
approved these changes
Nov 25, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses the root cause behind #20423. When an accessor that has not been constructed with a
handlerinstance is passed to theset_argsfunction of ahandlersuch as a default accessor, the lifetime of its dynamically allocated resources can potentially be shorter than the lifetime of thehandleritself which causes problems, for instance, in thefinalizefunction of thehandlerwhere we may end up accessing freed memory.