Skip to content

[UR] Add launchPropList to arguments of appendKernelLaunchWithArgsExpNew() #20666

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 19, 2025
+33 −25
Merged

[UR] Add launchPropList to arguments of appendKernelLaunchWithArgsExpNew() #20666

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
51 changes: 29 additions & 22 deletions unified-runtime/source/adapters/level_zero/v2/command_list_manager.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1141,9 +1141,10 @@ ur_result_t ur_command_list_manager::appendKernelLaunchWithArgsExpNew(
ur_kernel_handle_t hKernel, uint32_t workDim,
const size_t *pGlobalWorkOffset, const size_t *pGlobalWorkSize,
const size_t *pLocalWorkSize, uint32_t numArgs,
const ur_exp_kernel_arg_properties_t *pArgs, uint32_t numEventsInWaitList,
const ur_event_handle_t *phEventWaitList, ur_event_handle_t phEvent,
bool cooperativeKernelLaunchRequested) {
const ur_exp_kernel_arg_properties_t *pArgs,
const ur_kernel_launch_ext_properties_t *launchPropList,
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
ur_event_handle_t phEvent) {

ur_result_t checkResult = kernelLaunchChecks(hKernel, workDim);
if (checkResult != UR_RESULT_SUCCESS) {
Expand All @@ -1155,12 +1156,33 @@ ur_result_t ur_command_list_manager::appendKernelLaunchWithArgsExpNew(
ZeStruct<ze_command_list_append_launch_kernel_param_cooperative_desc_t>
cooperativeDesc;
cooperativeDesc.isCooperative = static_cast<ze_bool_t>(true);

void *pNext = nullptr;
if (cooperativeKernelLaunchRequested) {
bool cooperativeKernelLaunchRequested = false;

ur_kernel_launch_ext_properties_t *_launchPropList =
const_cast<ur_kernel_launch_ext_properties_t *>(launchPropList);
if (_launchPropList &&
_launchPropList->flags & UR_KERNEL_LAUNCH_FLAG_COOPERATIVE) {
cooperativeKernelLaunchRequested = true;
pNext = &cooperativeDesc;
}

if (_launchPropList &&
_launchPropList->flags & ~UR_KERNEL_LAUNCH_FLAG_COOPERATIVE) {
// We don't support any other flags.
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
}

while (_launchPropList != nullptr) {
if (_launchPropList->stype !=
as_stype<ur_kernel_launch_ext_properties_t>()) {
// We don't support any other properties.
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
}
_launchPropList = static_cast<ur_kernel_launch_ext_properties_t *>(
_launchPropList->pNext);
}

ze_kernel_handle_t hZeKernel = hKernel->getZeHandle(hDevice.get());

std::scoped_lock<ur_shared_mutex> Lock(hKernel->Mutex);
Expand Down Expand Up @@ -1225,27 +1247,12 @@ ur_result_t ur_command_list_manager::appendKernelLaunchWithArgsExp(

ur_kernel_launch_ext_properties_t *_launchPropList =
const_cast<ur_kernel_launch_ext_properties_t *>(launchPropList);
if (_launchPropList &&
_launchPropList->flags & ~UR_KERNEL_LAUNCH_FLAG_COOPERATIVE) {
// We don't support any other flags.
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
}

if (_launchPropList &&
_launchPropList->flags & UR_KERNEL_LAUNCH_FLAG_COOPERATIVE) {
cooperativeKernelLaunchRequested = true;
}

while (_launchPropList != nullptr) {
if (_launchPropList->stype !=
as_stype<ur_kernel_launch_ext_properties_t>()) {
// We don't support any other properties.
return UR_RESULT_ERROR_UNSUPPORTED_FEATURE;
}
_launchPropList = static_cast<ur_kernel_launch_ext_properties_t *>(
_launchPropList->pNext);
}

ur_platform_handle_t hPlatform = hContext->getPlatform();
bool KernelWithArgsSupported =
hPlatform->ZeCommandListAppendLaunchKernelWithArgumentsExt.Supported;
Expand All @@ -1259,8 +1266,8 @@ ur_result_t ur_command_list_manager::appendKernelLaunchWithArgsExp(
if (RunNewPath) {
return appendKernelLaunchWithArgsExpNew(
hKernel, workDim, pGlobalWorkOffset, pGlobalWorkSize, pLocalWorkSize,
numArgs, pArgs, numEventsInWaitList, phEventWaitList, phEvent,
cooperativeKernelLaunchRequested);
numArgs, pArgs, launchPropList, numEventsInWaitList, phEventWaitList,
phEvent);
} else {
// We cannot pass cooperativeKernelLaunchRequested to
// appendKernelLaunchWithArgsExpOld() because appendKernelLaunch() must
Expand Down
7 changes: 4 additions & 3 deletions unified-runtime/source/adapters/level_zero/v2/command_list_manager.hpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -256,9 +256,10 @@ struct ur_command_list_manager {
ur_kernel_handle_t hKernel, uint32_t workDim,
const size_t *pGlobalWorkOffset, const size_t *pGlobalWorkSize,
const size_t *pLocalWorkSize, uint32_t numArgs,
const ur_exp_kernel_arg_properties_t *pArgs, uint32_t numEventsInWaitList,
const ur_event_handle_t *phEventWaitList, ur_event_handle_t phEvent,
bool cooperativeKernelLaunchRequested);
const ur_exp_kernel_arg_properties_t *pArgs,
const ur_kernel_launch_ext_properties_t *launchPropList,
uint32_t numEventsInWaitList, const ur_event_handle_t *phEventWaitList,
ur_event_handle_t phEvent);

ur_result_t appendGenericCommandListsExp(
uint32_t numCommandLists, ze_command_list_handle_t *phCommandLists,
Expand Down
Loading