[UR] Add launchPropList to arguments of appendKernelLaunchWithArgsExpNew()
#20666
+33
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ldorau
force-pushed
the
Add_launchPropList_to_arguments_of_appendKernelLaunchWithArgsExpNew
branch
from
00cd27c to
5c0c4a7
Compare
ldorau
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
dyniols
approved these changes
Nov 18, 2025
pbalcer
reviewed
Nov 18, 2025
unified-runtime/source/adapters/level_zero/v2/command_list_manager.cpp
Outdated
Show resolved
Hide resolved
ldorau
force-pushed
the
Add_launchPropList_to_arguments_of_appendKernelLaunchWithArgsExpNew
branch
from
5c0c4a7 to
4d68df0
Compare
ldorau
force-pushed
the
Add_launchPropList_to_arguments_of_appendKernelLaunchWithArgsExpNew
branch
from
4d68df0 to
fe3fa7a
Compare
dyniols
approved these changes
Nov 18, 2025
ldorau
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
pbalcer
approved these changes
Nov 18, 2025
After replacing `urEnqueueKernelLaunch()` property list with `pNext` chain property structures (commit 66b3b53) the `appendKernelLaunchWithArgsExpNew()` function will need the list of properities, so add `launchPropList` to arguments of `appendKernelLaunchWithArgsExpNew()` (like in `appendKernelLaunchWithArgsExpOld()`). It is a preparation for future changes. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Contributor
Author
|
@kswiecicki please review |
kswiecicki
approved these changes
Nov 19, 2025
Contributor
|
UR pre-commit failures are related to: #20683. This PR shouldn't cause any issues, since it's just a parameters refactor. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After replacing
urEnqueueKernelLaunch()property list withpNextchain property structures (commit 66b3b53) theappendKernelLaunchWithArgsExpNew()function will need the list of properities, so addlaunchPropListto arguments ofappendKernelLaunchWithArgsExpNew()(like it is inappendKernelLaunchWithArgsExpOld()).It is a preparation for future changes.