Skip to content

[SYCL] Cleanup queue's submission ABI entry points #20675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 24, 2025
Merged

[SYCL] Cleanup queue's submission ABI entry points #20675

merged 7 commits into from
Nov 24, 2025

Conversation

@againull
Copy link
Contributor

@againull againull commented Nov 18, 2025

No description provided.

@againull
Copy link
Contributor Author

againull commented Nov 19, 2025 

Failed Tests (1):
  SYCL :: Matrix/joint_matrix_bfloat16_accumulator.cpp

is unrelated and known: #20594

@againull againull marked this pull request as ready for review November 19, 2025 22:26
@againull againull requested a review from a team as a code owner November 19, 2025 22:26
@againull againull requested a review from slawekptak November 19, 2025 22:26
slawekptak
slawekptak reviewed Nov 20, 2025
View reviewed changes
@againull againull requested a review from slawekptak November 20, 2025 17:24
aelovikov-intel
aelovikov-intel reviewed Nov 20, 2025
View reviewed changes
sycl/include/sycl/queue.hpp Outdated
namespace detail {
class queue_impl;

#ifndef __INTEL_PREVIEW_BREAKING_CHANGES
Copy link
Contributor

@aelovikov-intel aelovikov-intel Nov 20, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, the scope of this PR should be bigger and remove entire non-preview SubmissionInfo. But if others disagree I won't insist.

Copy link
Contributor

@slawekptak slawekptak Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@againull I would leave it up to you to decide.

@againull againull changed the title [SYCL] Remove fallback assertion ABI entry points [SYCL] Cleanup queue's submission ABI entry points Nov 21, 2025
@againull againull closed this Nov 24, 2025
@againull againull reopened this Nov 24, 2025
@againull againull merged commit b765a2e into intel:sycl Nov 24, 2025
32 of 34 checks passed
@bader bader mentioned this pull request Nov 25, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@aelovikov-intel aelovikov-intel aelovikov-intel approved these changes

@slawekptak slawekptak Awaiting requested review from slawekptak

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@againull @slawekptak @aelovikov-intel