[Driver] Fix preview breaking changes option passing to offload-wrapper #20708
Conversation
When passing options to the clang-offload-wrapper, the -fpreview-breaking-changes option needs to be passed accordingly to the tool when -fpreview-breaking-changes is used on the command line. This was happening for typical SYCL enabled compilations, but when using -fsycl-link, the usage of clang-offload-wrapper modifies the offloading kind encountered, causing the option to not be passed. Fixup the ability to pass -fpreview-breaking-changes for all needed uses as well as factoring in the offload-compress options which are in the same bucket of behaviors.
mdtoguchi
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/dpcpp-clang-driver-reviewers , please take a look. |
hchilama
left a comment
hchilama
left a comment
There was a problem hiding this comment.
Do we have a test case checking for offload-compress and offload-compression-level= ? if so LGTM
Is there a test case for this? |
| // and enabling preview breaking changes. | ||
| auto addCLIOptions = [&](ArgStringList &Args) -> void { | ||
| // -offload-compress | ||
| if (C.getInputArgs().getLastArg(options::OPT_offload_compress)) { |
There was a problem hiding this comment.
Does this have to be getLastArg and not just hasArg ?
| if (C.getInputArgs().getLastArg(options::OPT_offload_compress)) { | ||
| Args.push_back(C.getArgs().MakeArgString(Twine("-offload-compress"))); | ||
| // -offload-compression-level=<> | ||
| if (Arg *A = C.getInputArgs().getLastArg( |
There was a problem hiding this comment.
Same question as above.
Please update the description to also mention the changes related to : |
|
Precommit testing has this failure: |
3 participants
When passing options to the clang-offload-wrapper, the -fpreview-breaking-changes option needs to be passed accordingly to the tool when -fpreview-breaking-changes is used on the command line. This was happening for typical SYCL enabled compilations, but when using -fsycl-link, the usage of clang-offload-wrapper modifies the offloading kind encountered, causing the option to not be passed.
Fixup the ability to pass -fpreview-breaking-changes for all needed uses as well as factoring in the offload-compress options which are in the same bucket of behaviors.