[NewOffloadDriver] Fix SYCL E2E image compression test for new offload model #20717
+94
−8
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YixingZhang007
force-pushed
the
solve_compression_seperate_compile_test_failure
branch
from
3fa7d78 to
989b8e5
Compare
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YixingZhang007
force-pushed
the
solve_compression_seperate_compile_test_failure
branch
from
989b8e5 to
e9d3cca
Compare
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YixingZhang007
changed the title
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
Contributor
Author
|
The changes for enabling the new offloading model will be removed from this PR after the CI tests have finished verifying that the image compression SYCL E2E tests pass with the new offloading model. |
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
force-pushed
the
solve_compression_seperate_compile_test_failure
branch
from
aa7685a to
c8d4f76
Compare
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YixingZhang007
force-pushed
the
solve_compression_seperate_compile_test_failure
branch
from
d20abf6 to
8175ae1
Compare
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Contributor
Author
|
Both the tests |
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YixingZhang007
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
YixingZhang007
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
I don't think the current CI failure is related to the changes made in this PR. |
YixingZhang007
commented
Nov 25, 2025
|
|
||
| // REQUIRES: zstd, opencl-aot, cpu, linux | ||
|
|
||
| // XFAIL: run-mode && preview-mode |
Contributor
Author
There was a problem hiding this comment.
Surprisingly, this test fails for the preview-mode for old offloading model; however, for the new offloading model, it passes. Therefore // XFAIL: run-mode && preview-mode is not added in NewOffloadDriver/image_compression.cpp.
Contributor
There was a problem hiding this comment.
The issue with the preview-mode failing is being addressed here: #20708
Contributor
Author
There was a problem hiding this comment.
Thanks for pointing this out! In this case, I think this behavior is expected, and the test will also pass with preview-mode for old offloading model after #20708 is merged :)
Contributor
Author
|
@intel/llvm-reviewers-runtime Could you please help review this PR? Thank you :) |
uditagarwal97
approved these changes
Nov 26, 2025
Contributor
uditagarwal97
left a comment
uditagarwal97
left a comment
There was a problem hiding this comment.
LGTM. Thanks for fixing this test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch addresses test failures in SYCL E2E image compression by testing this feature for two offloading models in separate tests:
(1) The
--no-offload-new-driverflag is added to the test command inCompression/compression_separate_compile.cpp. This ensures the test uses the old offloading model whereclang-offload-wrapper(which the test validates) is actually invoked.(2) Created a new test file
NewOffloadDriver/image_compression.cppto verify image compression functionality works correctly with the new offloading driver.With this patch, the
Compression/compression_separate_compile.cppSYCL E2E test will pass with the new offloading model.