[SYCL RTC] Exclude libdevice's .o/.spv files from resources
#20759
Conversation
aelovikov-intel
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
We only use `.bc` files from libdevice. Another potential implementation for this was to update libdevice's CMakeLists.txt to have separate `libdevice-bc` and `libdevice-non-bc` install components and only install the former into `rtc-resoruce-install` directory. However, that would be intrusive to libdevice with zero benefit there, so I decided to do the filter on the sycl-jit's side inside `generate.py`.
aelovikov-intel
force-pushed
the
libdevice-bc-only
branch
from
138dba1 to
8821e2e
Compare
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
requested review from
a team and
cperkinsintel
as code owners
|
@intel/llvm-reviewers-runtime , Chris is on vacation, can someone review this? |
|
|
||
| def process_file(file_path): | ||
| # We only need .bc files from libdevice: | ||
| if re.search(r"[/\\]libsycl-.*\.(o|obj|spv)$", file_path): |
There was a problem hiding this comment.
would it be simpler to just check if it ends in .bc than to check if it is not bc?
There was a problem hiding this comment.
This is used for .h/.hpp/.inc/etc. files as well (when processing components other than libdevice).
There was a problem hiding this comment.
maybe im being pedantic but would something like this work?
if "libsycl-" in file_path and file_path.endswith(".bc"):
return
There was a problem hiding this comment.
Let me re-phrase, it's better to embed more than not to embed something necessary. As such, I think matching a subset of known exclusions is better that skipping everything other than a few known pieces.
As for your exact suggestion, I think you're missing a negation (or I wasn't clear somewhere). .bc are the ones we need, so we shouldn't early return for them.
There was a problem hiding this comment.
ah yeah sorry the second part needs a negation, but with your explanation it lgtm as is
2 participants
We only use
.bcfiles from libdevice. Another potential implementation for this was to update libdevice's CMakeLists.txt to have separatelibdevice-bcandlibdevice-non-bcinstall components and only install the former intortc-resoruce-installdirectory. However, that would be intrusive to libdevice with zero benefit there, so I decided to do the filter on the sycl-jit's side insidegenerate.py.