[Clang][Test] Remove sycl-bc-device-libraries.cpp's dependency on libspirv files #20791
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…spirv files Also add `REQUIRES: amdgpu-registered-target` to fix `Unknown command line argument '-amdgpu-internalize-symbols'` error when generating %t.amd.o. Closes intel#20784
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
mdtoguchi
reviewed
Dec 2, 2025
|
|
||
| /// Check devicelib and libspirv are linked for nvptx. | ||
| /// amdgpu-registered-target is required for generating %t.amd.o. | ||
| // REQUIRES: amdgpu-registered-target |
Contributor
There was a problem hiding this comment.
This seems restrictive for any tests that are testing nvidia targets only. Is that scenario important?
Contributor
Author
There was a problem hiding this comment.
This seems restrictive for any tests that are testing nvidia targets only. Is that scenario important?
done, removed REQUIRES: amdgpu-registered-target in 7e3ed1b.
Added -fgpu-rdc as a workaround to prevent the Clang driver from passing -amdgpu-internalize-symbols to LLVM.
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also add
-fgpu-rdcto fixUnknown command line argument '-amdgpu-internalize-symbols'error when generating %t.amd.o.Closes #20784