Skip to content

[CI] Remove useless always() #20793

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 2, 2025
Merged

[CI] Remove useless always() #20793

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions devops/actions/run-tests/cts/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,12 +68,12 @@ runs:
ninja -C build-cts -k0 $( [ -n "$CTS_TESTS_TO_BUILD" ] && echo "$CTS_TESTS_TO_BUILD" || echo "test_conformance")
- name: Pack SYCL-CTS binaries
if: always() && !cancelled() && inputs.testing_mode == 'build-only'
if: ${{ !cancelled() && inputs.testing_mode == 'build-only' }}
shell: bash
run: tar -I 'zstd -9' -cf sycl_cts_bin.tar.zst -C ./build-cts/bin .

- name: Upload SYCL-CTS binaries
if: always() && !cancelled() && inputs.testing_mode == 'build-only'
if: ${{ !cancelled() && inputs.testing_mode == 'build-only' }}
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.binaries_artifact }}
Expand All @@ -95,7 +95,7 @@ runs:
- name: SYCL CTS List devices
# Proceed with execution even if the 'build' step did not succeed.
if: (always() && !cancelled()) && inputs.testing_mode != 'build-only'
if: ${{ !cancelled()) && inputs.testing_mode != 'build-only' }}
shell: bash
env:
ONEAPI_DEVICE_SELECTOR: ${{ inputs.target_devices }}
Expand Down Expand Up @@ -129,7 +129,7 @@ runs:
- name: Run SYCL CTS tests
# Proceed with execution even if the previous two steps did not succeed.
if: (always() && !cancelled()) && inputs.testing_mode != 'build-only'
if: ${{ !cancelled()) && inputs.testing_mode != 'build-only' }}
env:
ONEAPI_DEVICE_SELECTOR: ${{ inputs.target_devices }}
# By-default GitHub actions execute the "run" shell script with -e option,
Expand Down
4 changes: 2 additions & 2 deletions devops/actions/run-tests/e2e/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,12 +95,12 @@ runs:
exit 1

- name: Pack E2E binaries
if: ${{ always() && !cancelled() && inputs.binaries_artifact != '' && inputs.testing_mode != 'run-only'}}
if: ${{ !cancelled() && inputs.binaries_artifact != '' && inputs.testing_mode != 'run-only' }}
shell: bash
run: |
tar -I 'zstd -9' -cf e2e_binaries.tar.zst -C ./build-e2e .
- name: Upload E2E binaries
if: ${{ always() && !cancelled() && inputs.binaries_artifact != '' && inputs.testing_mode != 'run-only'}}
if: ${{ !cancelled() && inputs.binaries_artifact != '' && inputs.testing_mode != 'run-only' }}
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.binaries_artifact }}
Expand Down
8 changes: 4 additions & 4 deletions devops/actions/run-tests/windows/cts/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,12 @@ runs:
ninja -C build-cts -k0 $( [ -n "$CTS_TESTS_TO_BUILD" ] && echo "$CTS_TESTS_TO_BUILD" || echo "test_conformance")
- name: Pack SYCL-CTS binaries
if: always() && !cancelled() && inputs.testing_mode == 'build-only'
if: ${{ !cancelled() && inputs.testing_mode == 'build-only' }}
shell: bash
run: tar -I 'zstd -9' -cf sycl_cts_bin.tar.zst -C ./build-cts/bin .

- name: Upload SYCL-CTS binaries
if: always() && !cancelled() && inputs.testing_mode == 'build-only'
if: ${{ !cancelled() && inputs.testing_mode == 'build-only' }}
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.binaries_artifact }}
Expand All @@ -97,7 +97,7 @@ runs:
- name: SYCL CTS List devices
# Proceed with execution even if the 'build' step did not succeed.
if: (always() && !cancelled()) && inputs.testing_mode != 'build-only'
if: ${{ !cancelled()) && inputs.testing_mode != 'build-only' }}
shell: bash
env:
ONEAPI_DEVICE_SELECTOR: ${{ inputs.target_devices }}
Expand Down Expand Up @@ -131,7 +131,7 @@ runs:
- name: Run SYCL CTS tests
# Proceed with execution even if the previous two steps did not succeed.
if: (always() && !cancelled()) && inputs.testing_mode != 'build-only'
if: ${{ !cancelled()) && inputs.testing_mode != 'build-only' }}
env:
ONEAPI_DEVICE_SELECTOR: ${{ inputs.target_devices }}
# By-default GitHub actions execute the "run" shell script with -e option,
Expand Down
8 changes: 4 additions & 4 deletions devops/actions/run-tests/windows/e2e/action.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ runs:
cmake -GNinja -B build-e2e -S./llvm/sycl/test-e2e -DCMAKE_CXX_COMPILER="${{ inputs.sycl_compiler || '$(which clang++).exe' }}" -DLEVEL_ZERO_LIBS_DIR="D:\\github\\level-zero_win-sdk\\lib" -DLEVEL_ZERO_INCLUDE="D:\\github\\level-zero_win-sdk\\include" -DLLVM_LIT="..\\llvm\\llvm\\utils\\lit\\lit.py" ${{ steps.cmake_opts.outputs.opts }}

- name: Keep track of files after configuring E2E step
if: ${{ always() && !cancelled() && inputs.binaries_artifact != '' && inputs.testing_mode != 'run-only'}}
if: ${{ !cancelled() && inputs.binaries_artifact != '' && inputs.testing_mode != 'run-only' }}
shell: bash
run: ls build-e2e > e2econf_files.txt

Expand Down Expand Up @@ -103,19 +103,19 @@ runs:
# CMake issues related to absolute paths we reconfigure the build-e2e
# folder on the run system.
- name: Remove E2E configuration files
if: ${{ always() && !cancelled() && inputs.binaries_artifact != '' && inputs.testing_mode != 'run-only'}}
if: ${{ !cancelled() && inputs.binaries_artifact != '' && inputs.testing_mode != 'run-only' }}
shell: bash
run: |
for FILE in $(cat e2econf_files.txt); do rm -r build-e2e/$FILE; done
rm e2econf_files.txt

- name: Pack E2E test binaries
if: ${{ always() && !cancelled() && inputs.binaries_artifact != '' && inputs.testing_mode != 'run-only'}}
if: ${{ !cancelled() && inputs.binaries_artifact != '' && inputs.testing_mode != 'run-only' }}
shell: bash
run: |
tar -czf e2e_bin.tar.gz -C build-e2e .
- name: Upload E2E test binaries
if: ${{ always() && !cancelled() && inputs.binaries_artifact != '' && inputs.testing_mode != 'run-only'}}
if: ${{ !cancelled() && inputs.binaries_artifact != '' && inputs.testing_mode != 'run-only' }}
uses: actions/upload-artifact@v4
with:
name: ${{ inputs.binaries_artifact }}
Expand Down
Loading