[NFCI][SYCL] Consolidate [get|create]SyclObj[From]Impl into ImplUtils
#20798
+100
−377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way much less `friend` declarations are needed.
aelovikov-intel
requested review from
KseniyaTikhomirova,
adamfidel,
sergey-semenov and
slawekptak
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
changed the title
[get|create]SyclObj[From]Impl into ImplUtils`[get|create]SyclObj[From]Impl into ImplUtils
aelovikov-intel
commented
Dec 2, 2025
Contributor
Author
aelovikov-intel
left a comment
aelovikov-intel
left a comment
There was a problem hiding this comment.
With that, I'm not even sure if detail::ObjBase is necessary... However, even if it is, it would be easier to introduce it on top of this PR.
Comment on lines
-56
to
-58
| std::add_lvalue_reference_t<typename std::remove_reference_t< | ||
| decltype(getSyclObjImpl(std::declval<T>()))>::element_type> | ||
| ImplRef) { |
Contributor
Author
There was a problem hiding this comment.
Technically, I could preserve this SFINAE logic but I don't see much value in doing that.
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
aelovikov-intel
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
adamfidel
approved these changes
Dec 2, 2025
Member
adamfidel
left a comment
adamfidel
left a comment
There was a problem hiding this comment.
Graph changes make sense. They are in line with the changes to the rest of the files.
cperkinsintel
approved these changes
Dec 3, 2025
steffenlarsen
approved these changes
Dec 3, 2025
Contributor
steffenlarsen
left a comment
steffenlarsen
left a comment
There was a problem hiding this comment.
Massive improvement. Good thinking! 🚀
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This way much less
frienddeclarations are needed.