Skip to content

[Bench] Use L0v2 adapter for v2 benchmarks #20897

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
steffenlarsen merged 1 commit into from
Dec 16, 2025
Merged

[Bench] Use L0v2 adapter for v2 benchmarks #20897

steffenlarsen merged 1 commit into from
Dec 16, 2025

Conversation

@lukaszstolarczuk
Copy link
Contributor

@lukaszstolarczuk lukaszstolarczuk commented Dec 15, 2025

No description provided.

PatKamin
PatKamin reviewed Dec 16, 2025
View reviewed changes
devops/actions/run-tests/benchmark/action.yml Outdated
level_zero_v2:*)
SAVE_SUFFIX="L0v2"
ONEAPI_DEVICE_SELECTOR="level_zero:gpu"
ONEAPI_DEVICE_SELECTOR="level_zero_v2:gpu"
Copy link
Contributor

@PatKamin PatKamin Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should not change

Copy link
Contributor Author

@lukaszstolarczuk lukaszstolarczuk Dec 16, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

right, fixed rather adapter param

@lukaszstolarczuk lukaszstolarczuk changed the title Fix bench v2 [Bench] Use L0v2 selector for v2 benchmarks Dec 16, 2025
@lukaszstolarczuk lukaszstolarczuk changed the title [Bench] Use L0v2 selector for v2 benchmarks [Bench] Use L0v2 adapter for v2 benchmarks Dec 16, 2025
@lukaszstolarczuk lukaszstolarczuk marked this pull request as ready for review December 16, 2025 09:32
@lukaszstolarczuk lukaszstolarczuk requested a review from a team as a code owner December 16, 2025 09:32
@lukaszstolarczuk
Copy link
Contributor Author

lukaszstolarczuk commented Dec 16, 2025

// tested on PR on matrix od backends/runners
https://github.com/intel/llvm/actions/runs/20261761323 - looks ok (red status is due to integrations tests fails, but they were never run on BMG, only PVC)

@PatKamin
Copy link
Contributor

PatKamin commented Dec 16, 2025

// tested on PR on matrix od backends/runners https://github.com/intel/llvm/actions/runs/20261761323 - looks ok (red status is due to integrations tests fails, but they were never run on BMG, only PVC)

Results were not uploaded to the dashboard, please verify why.

@lukaszstolarczuk
Copy link
Contributor Author

lukaszstolarczuk commented Dec 16, 2025

// tested on PR on matrix od backends/runners https://github.com/intel/llvm/actions/runs/20261761323 - looks ok (red status is due to integrations tests fails, but they were never run on BMG, only PVC)

Results were not uploaded to the dashboard, please verify why.

PRs (from forks) do not have the write access. Here's a dispatch test - results look right on track again:

https://intel.github.io/llvm/benchmarks/?runs=pr_fix_v2_test_BMG_L0v2%2CBaseline_BMG_L0v2%2CBaseline_BMG_L0

@lukaszstolarczuk
Copy link
Contributor Author

lukaszstolarczuk commented Dec 16, 2025

@intel/llvm-gatekeepers , please merge

@steffenlarsen steffenlarsen merged commit aa1f770 into intel:sycl Dec 16, 2025
21 checks passed
@lukaszstolarczuk lukaszstolarczuk deleted the fix-bench-v2 branch December 16, 2025 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@PatKamin PatKamin PatKamin approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukaszstolarczuk @PatKamin @steffenlarsen