Skip to content

Conversation

@uditagarwal97
Copy link
Contributor

@uditagarwal97 uditagarwal97 commented Dec 16, 2025

Windows ABI test broke after #20821

@uditagarwal97 uditagarwal97 self-assigned this Dec 16, 2025
@uditagarwal97 uditagarwal97 requested a review from a team as a code owner December 16, 2025 04:05
@uditagarwal97 uditagarwal97 changed the title [SYCL][LIT] Update Windows ABI test [SYCL][LIT] Fix Windows ABI test Dec 16, 2025
@uditagarwal97
Copy link
Contributor Author

Looks like different ABI symbols are being generated for Windows pre and post commit.
Unlike pre-commit, for post-commit, the following symbols are absent:

??0device@_V1@sycl@@QEAA@$$QEAV012@@Z
??0device@_V1@sycl@@QEAA@AEBV012@@Z

One difference is that pre-commit uses MSVC's cl while post-commit uses icx - I wonder if different compilers are generating different ABI symbols.

@steffenlarsen
Copy link
Contributor

One difference is that pre-commit uses MSVC's cl while post-commit uses icx - I wonder if different compilers are generating different ABI symbols.

That sounds somewhat likely, but maybe we can trick the latter to think that the symbols are exported.

@sarnex
Copy link
Contributor

sarnex commented Dec 16, 2025

Can we commit a test fix and follow-it up with a better fix if needed or revert the original commit? Thanks

@uditagarwal97
Copy link
Contributor Author

Can we commit a test fix and follow-it up with a better fix if needed or revert the original commit? Thanks

I'm trying to come up with a proper fix. In the meanwhile, I'd be fine disabling this test - we are anyway in the ABI break window

@sarnex
Copy link
Contributor

sarnex commented Dec 16, 2025

Fine with me, thx!

@uditagarwal97 uditagarwal97 changed the title [SYCL][LIT] Fix Windows ABI test [SYCL][LIT] XFAIL sycl/test/abi/sycl_symbols_windows.dump on Windows Dec 16, 2025
@uditagarwal97 uditagarwal97 changed the title [SYCL][LIT] XFAIL sycl/test/abi/sycl_symbols_windows.dump on Windows [SYCL][LIT] UNSUPPORTED sycl/test/abi/sycl_symbols_windows.dump on Windows Dec 16, 2025
@uditagarwal97 uditagarwal97 merged commit c3cdb9f into sycl Dec 16, 2025
27 of 29 checks passed
@uditagarwal97 uditagarwal97 deleted the private/udit/win_abi branch December 16, 2025 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants