-
Notifications
You must be signed in to change notification settings - Fork 801
[SYCL][LIT] UNSUPPORTED sycl/test/abi/sycl_symbols_windows.dump on Windows
#20902
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Looks like different ABI symbols are being generated for Windows pre and post commit. One difference is that pre-commit uses MSVC's |
That sounds somewhat likely, but maybe we can trick the latter to think that the symbols are exported. |
|
Can we commit a test fix and follow-it up with a better fix if needed or revert the original commit? Thanks |
I'm trying to come up with a proper fix. In the meanwhile, I'd be fine disabling this test - we are anyway in the ABI break window |
|
Fine with me, thx! |
sycl/test/abi/sycl_symbols_windows.dump on Windows
sycl/test/abi/sycl_symbols_windows.dump on Windowssycl/test/abi/sycl_symbols_windows.dump on Windows
Windows ABI test broke after #20821