[SYCL] Run EarlyCSEPass to eliminate redundant memory ops after SYCLLowerWGLocalMemoryPass #21030
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…owerWGLocalMemoryPass In SYCL early optimization pipeline, EarlyCSEPass is currently missing after SYCLLowerWGLocalMemoryPass. This PR adds it to VectorizerStartEPCallback which is the first function pass callback following AlwaysInlinerPass. In pytorch_microbench/kernel-submit-slm-size--1 (Jira GSD-12161), adding EarlyCSEPass can eliminates %4 and replace it with %2: store ptr addrspace(3) %2, ptr addrspace(3) @__sycl_dynamicLocalMemoryPlaceholder_GV %4 = load ptr addrspace(3), ptr addrspace(3) @__sycl_dynamicLocalMemoryPlaceholder_GV
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
wenju-he
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
wenju-he
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
YuriPlyakhin
approved these changes
Jan 12, 2026
wenju-he
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
Fznamznon
approved these changes
Jan 13, 2026
Contributor
Author
|
Windows BMG fail @intel/llvm-gatekeepers please merge, thanks |
wenju-he
deleted the
sycl-registerVectorizerStartEPCallback-EarlyCSEPass
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a regression from d8ba6b5: a missed optimization when target is SPIR-V.
In SYCL early optimization pipeline, EarlyCSEPass is currently missing after SYCLLowerWGLocalMemoryPass. This PR adds it to VectorizerStartEPCallback which is the first function pass callback following AlwaysInlinerPass.
In pytorch_microbench/kernel-submit-slm-size--1 (Jira GSD-12161), adding EarlyCSEPass can eliminates %4 and replace it with %2:
store ptr addrspace(3) %2, ptr addrspace(3) @__sycl_dynamicLocalMemoryPlaceholder_GV
%4 = load ptr addrspace(3), ptr addrspace(3) @__sycl_dynamicLocalMemoryPlaceholder_GV