add option to select build_image when manually running benchmarks#21051
Open
lslusarczyk wants to merge 1 commit intointel:syclfrom
Open
add option to select build_image when manually running benchmarks#21051lslusarczyk wants to merge 1 commit intointel:syclfrom
lslusarczyk wants to merge 1 commit intointel:syclfrom
Conversation
Contributor
lukaszstolarczuk
left a comment
lukaszstolarczuk
left a comment
There was a problem hiding this comment.
let's hold on with this PR, I'll verify if this works as we'd expect
| default: 'false' | ||
| build_image: | ||
| type: string | ||
| description: | |
Contributor
There was a problem hiding this comment.
I'd say it should just be description: Docker image used for building and benchmarking
| description: | | ||
| Docker image used for building SYCL UR benchmarks | ||
| required: false | ||
| default: '' |
Contributor
There was a problem hiding this comment.
default could be already: "ghcr.io/intel/llvm/sycl_ubuntu2404_nightly:latest" so we could skip the {{ || }} syntax below
pls note it's _nightly, not _build as you have now
| - 'false' | ||
| - 'true' | ||
| default: 'false' | ||
| build_image: |
Contributor
There was a problem hiding this comment.
I'd rename to docker_image as it's used for both - building and benchmarking
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To be able to manually run benchmarks on modified compute-runtime.