Skip to content

[UR][SYCL] Add urCommandBufferAppendKernelLaunchWithArgsExp()#21110

Merged
sarnex merged 6 commits intointel:syclfrom
ldorau:Add_urCommandBufferAppendKernelLaunchWithArgsExp
Feb 25, 2026
Merged

[UR][SYCL] Add urCommandBufferAppendKernelLaunchWithArgsExp()#21110
sarnex merged 6 commits intointel:syclfrom
ldorau:Add_urCommandBufferAppendKernelLaunchWithArgsExp

Conversation

@ldorau
Copy link
Contributor

@ldorau ldorau commented Jan 23, 2026

No description provided.

@ldorau ldorau force-pushed the Add_urCommandBufferAppendKernelLaunchWithArgsExp branch from 2cc6349 to 0dc6aa2 Compare January 23, 2026 13:37
@ldorau ldorau force-pushed the Add_urCommandBufferAppendKernelLaunchWithArgsExp branch from 0dc6aa2 to 822f68f Compare January 23, 2026 14:14
@ldorau ldorau force-pushed the Add_urCommandBufferAppendKernelLaunchWithArgsExp branch from 822f68f to cf7d715 Compare January 23, 2026 14:54
@ldorau ldorau force-pushed the Add_urCommandBufferAppendKernelLaunchWithArgsExp branch from cf7d715 to ec70d72 Compare January 23, 2026 14:57
@ldorau ldorau force-pushed the Add_urCommandBufferAppendKernelLaunchWithArgsExp branch from ec70d72 to a8e440b Compare February 3, 2026 10:32
@ldorau ldorau force-pushed the Add_urCommandBufferAppendKernelLaunchWithArgsExp branch from a8e440b to 91cfcc5 Compare February 3, 2026 10:34
@ldorau ldorau force-pushed the Add_urCommandBufferAppendKernelLaunchWithArgsExp branch from 73defce to 2adcdcb Compare February 6, 2026 07:25
@ldorau
Copy link
Contributor Author

ldorau commented Feb 11, 2026

The CUDA test fails because of #19688
The HIP test fails because of #18763

@ldorau
Copy link
Contributor Author

ldorau commented Feb 11, 2026

The HIP test fails because of #18763

@ldorau
Copy link
Contributor Author

ldorau commented Feb 12, 2026

Rebased

@ldorau
Copy link
Contributor Author

ldorau commented Feb 12, 2026

Please review

@ldorau
Copy link
Contributor Author

ldorau commented Feb 13, 2026

Rebased

@ldorau
Copy link
Contributor Author

ldorau commented Feb 16, 2026

Everyone - please review

@ldorau
Copy link
Contributor Author

ldorau commented Feb 23, 2026

Rebased

Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Commit output of 'make generate'.

Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
@ldorau
Copy link
Contributor Author

ldorau commented Feb 23, 2026

Please review

Copy link
Member

@adamfidel adamfidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Besides a minor change to a comment, LGTM. I mainly looked at the graph changes and some of the L0 adapter.

&redefinedCommandBufferAppendKernelLaunchWithArgsExpAfter);

ASSERT_NO_THROW(Graph.finalize(experimental::property::graph::updatable{}));
// GetInfo and AppendKernelLaunch should be called once each time a node is
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
// GetInfo and AppendKernelLaunch should be called once each time a node is
// GetInfo and AppendKernelLaunchWithArgs should be called once each time a node is

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@ldorau
Copy link
Contributor Author

ldorau commented Feb 24, 2026

Please review @intel/unified-runtime-reviewers-opencl @intel/dpcpp-nativecpu-reviewers @intel/llvm-reviewers-cuda
@intel/llvm-reviewers-runtime

@ldorau
Copy link
Contributor Author

ldorau commented Feb 25, 2026

One CI check fails because of hung tests detected on a CI machine.

@ldorau
Copy link
Contributor Author

ldorau commented Feb 25, 2026

Please review @intel/unified-runtime-reviewers-opencl @intel/dpcpp-nativecpu-reviewers @intel/llvm-reviewers-cuda
@intel/llvm-reviewers-runtime

@ldorau
Copy link
Contributor Author

ldorau commented Feb 25, 2026

Please review @intel/llvm-reviewers-runtime

@ldorau
Copy link
Contributor Author

ldorau commented Feb 25, 2026

@intel/llvm-gatekeepers please merge

The SYCL Pre Commit on Windows / run_prebuilt_e2e_tests (Intel Arc Graphics with Level Zero) CI job keeps failing because of #20750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants