Draft
Conversation
…to properly populate the UR ur_image_desc_t.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The bindless image
image_descriptordoes not have pitch/slice. We need that to properly create aur_image_desc_t. Without it we'll never be able to support linear images that have aligned strides. There are also some older SYCL 1.2.1 defensive checks that will also block.Added a unit test that demonstrates that these values correctly arrive at the UR.
Here is the
ur_image_desc_tfrom ur_api.h in case anyone is wondering: