[Driver][NFC] Check pointer Arg before dereferencing.#21287
[Driver][NFC] Check pointer Arg before dereferencing.#21287srividya-sundaram wants to merge 3 commits intointel:syclfrom
Conversation
srividya-sundaram
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
srividya-sundaram
had a problem deploying
to
WindowsCILock
GitHub Actions
Failure
srividya-sundaram
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
srividya-sundaram
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
| Arg *SYCLSplitMode = | ||
| Args.getLastArg(options::OPT_fsycl_device_code_split_EQ); | ||
| Arg *OffloadLTO = Args.getLastArg(options::OPT_foffload_lto, | ||
| options::OPT_foffload_lto_EQ); |
There was a problem hiding this comment.
This looks like something that would benefit the community as it isn't specific to SYCL. Would this be better to just upstream instead of doing intel/llvm?
There was a problem hiding this comment.
There are to SYCL specific checks here before some of these diagnostics are emitted (like SYCLSplitMode). Unless I am mis-understanding what you are referring to.
There was a problem hiding this comment.
Yes, there are SYCL specific things here, but the fix itself can be applied to upstream and be pulled into intel/llvm as it also impacts OpenMP upstream behaviors.
There was a problem hiding this comment.
but the fix itself can be applied to upstream and be pulled into intel/llvm as it also impacts OpenMP upstream behaviors.
err_drv_sycl_thinlto_split_off is specific to intel/llvm only and is therefore handled here, while the other two diagnostics are addressed in the upstream patch.
srividya-sundaram
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
srividya-sundaram
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
srividya-sundaram
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
srividya-sundaram
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
srividya-sundaram
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
srividya-sundaram
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
|
@intel/llvm-gatekeepers please consider merging |
2 participants
Addresses: #21282