[UR][CUDA][HIP][OpenCL] Return UNSUPPORTED_ENUMERATION for unknown de…#21295
Open
[UR][CUDA][HIP][OpenCL] Return UNSUPPORTED_ENUMERATION for unknown de…#21295
Conversation
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
changed the title
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
had a problem deploying
to
WindowsCILock
GitHub Actions
Error
kekaczma
force-pushed
the
defensive-enum-handling
branch
from
257552c to
d7a20fe
Compare
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
…vice info queries Handle unknown device info queries gracefully by returning UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION instead of UR_RESULT_ERROR_INVALID_ENUMERATION or breaking to unreachable code. This provides forward compatibility when newer SYCL runtimes query device info enums that don't exist in older UR adapters yet. Changes: - CUDA adapter: Return UNSUPPORTED_ENUMERATION + add error logging - HIP adapter: Return UNSUPPORTED_ENUMERATION + add error logging - OpenCL adapter: Return UNSUPPORTED_ENUMERATION - Remove unreachable return statements after default cases
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
kekaczma
temporarily deployed
to
WindowsCILock
GitHub Actions
Inactive
Contributor
Author
|
Failing check is related with known issue #21114 |
Contributor
|
@pbalcer please review - this should improve potential library mismatch issues in the adapters discovery path |
kekaczma
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…vice info queries
Handle unknown device info queries gracefully by returning UR_RESULT_ERROR_UNSUPPORTED_ENUMERATION instead of UR_RESULT_ERROR_INVALID_ENUMERATION or breaking to unreachable code.
This provides forward compatibility when newer SYCL runtimes query device info enums that don't exist in older UR adapters yet.
Changes: