[SYCL][JM] Support different types for the store#21398
Draft
dkhaldi wants to merge 4 commits intointel:syclfrom
Draft
[SYCL][JM] Support different types for the store#21398dkhaldi wants to merge 4 commits intointel:syclfrom
dkhaldi wants to merge 4 commits intointel:syclfrom
Conversation
sycl/test-e2e/Matrix/Inputs/joint_matrix_store_diff_types_impl.hpp
Outdated
Show resolved
Hide resolved
Contributor
There was a problem hiding this comment.
I am not sure if we should cast A to be float here, because A is Tp*, after we cast it, pA will be Tjm* (since Tjm is float). Then, later in the test, the matrix being passed into joint_matrix_store, as well as the pointer will have the same type which are both float* (but I thought they should have different types).
Contributor
Author
There was a problem hiding this comment.
Thanks for the catch.
It turns out the store from float to half is not working properly. That cast that I missed was masking the bug.
I am setting the test to XFAIL
Contributor
|
Thank you so much for making the change! I have added some suggestion :) |
YixingZhang007
approved these changes
Mar 11, 2026
Contributor
YixingZhang007
left a comment
YixingZhang007
left a comment
There was a problem hiding this comment.
LGTM! Thank you for the PR!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Complete the implementation of joint_matrix_store as in the spec, types of pointer and matrix can be different. See https://github.com/intel/llvm/blob/sycl/sycl/doc/extensions/experimental/sycl_ext_matrix/sycl_ext_oneapi_matrix.asciidoc#store
But in current implementation, we only support one type for both.
This PR adds this distinction.