[NFC] Optimize kernel traversal in CompileTimePropertiesPass.#21434
Merged
bader merged 1 commit intointel:syclfrom Mar 4, 2026
Merged
[NFC] Optimize kernel traversal in CompileTimePropertiesPass.#21434bader merged 1 commit intointel:syclfrom
bader merged 1 commit intointel:syclfrom
Conversation
This patch improves KernelCache to capture kernels for any target rather than just for NVPTX and AMDGCN. Use kernel information captured by the KernelCache to traverse kernels in CompileTimePropertiesPass. NOTE: KernelCache is also used by GlobalOffset.cpp, but corresponding pass explictly applies only to modules with NVPTX and AMDGCN target triples. This means that KernelCache improvement has no impact on GlobalOffsetPass.
YuriPlyakhin
approved these changes
Mar 4, 2026
Contributor
Author
|
Pre-commit failures are unrelated. |
Contributor
Author
|
Post-commit failures are unrelated as well. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch improves KernelCache to capture kernels for any target rather
than just for NVPTX and AMDGCN. Use kernel information captured by the
KernelCache to traverse kernels in CompileTimePropertiesPass.
NOTE: KernelCache is also used by GlobalOffset.cpp, but corresponding
pass explictly applies only to modules with NVPTX and AMDGCN target
triples. This means that KernelCache improvement has no impact on
GlobalOffsetPass.