[UR] Change ordinals of two files in UR spec#21440
Merged
sarnex merged 2 commits intointel:syclfrom Mar 4, 2026
Merged
Conversation
Contributor
Author
|
The essential change of this PR is located in only one commit (+2 / -2): bffa602 |
kswiecicki
approved these changes
Mar 4, 2026
adamfidel
approved these changes
Mar 4, 2026
ldorau
force-pushed
the
Change_ordinals_of_two_files
branch
from
13f6dcb to
7525a37
Compare
Contributor
Author
|
Rebased |
Contributor
Author
|
@intel/llvm-gatekeepers please merge |
Change ordinals of two files: - unified-runtime/scripts/core/exp-enqueue-kernel-launch-with-args.yml - unified-runtime/scripts/core/kernel.yml The following files have to be in the following order now: ordinal "10" - unified-runtime/scripts/core/enqueue.yml ordinal "11" - unified-runtime/scripts/core/exp-enqueue-kernel-launch-with-args.yml ordinal "12" - unified-runtime/scripts/core/kernel.yml because we will add a new `urKernelGetSuggestedLocalWorkSizeWithArgs()` API to `kernel.yml` that uses `ur_exp_kernel_arg_properties_t` which is defined in `exp-enqueue-kernel-launch-with-args.yml`, but `exp-enqueue-kernel-launch-with-args.yml` uses `ur_kernel_launch_ext_properties_t` which is defined in `enqueue.yml`. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
Commit output of make generate. Signed-off-by: Lukasz Dorau <lukasz.dorau@intel.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change ordinals of two files:
The following files have to be in the following order now:
ordinal "10" - unified-runtime/scripts/core/enqueue.yml
ordinal "11" - unified-runtime/scripts/core/exp-enqueue-kernel-launch-with-args.yml
ordinal "12" - unified-runtime/scripts/core/kernel.yml
because we will add a new
urKernelGetSuggestedLocalWorkSizeWithArgs()API (see #21442)to
kernel.ymlthat usesur_exp_kernel_arg_properties_twhich is defined in
exp-enqueue-kernel-launch-with-args.yml,but
exp-enqueue-kernel-launch-with-args.ymlusesur_kernel_launch_ext_properties_twhich is defined inenqueue.yml.Ref: #21442