-
Notifications
You must be signed in to change notification settings - Fork 824
[SYCL] Fix bug in enqueue free functions implementation #21461
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
31 commits
Select commit
Hold shift + click to select a range
b5ac52a
Implement free function kernel enqueue functions
lbushi25 63d860c
Remove unused code
lbushi25 00e0f0d
Improve comments
lbushi25 cd92d0c
Fix LIT command typo
lbushi25 4621ff6
Fix compilation error
lbushi25 76e0f8b
Fix unused argument error
lbushi25 ce2a16b
Fix unit-tests failures
lbushi25 e88b0f9
Fix formatting
lbushi25 b1b3ce9
Add XFAIL for native CPU
lbushi25 8b685ea
Add more tests
lbushi25 4cc1d15
Add a templated kernel test
lbushi25 4e7847d
Add a test to check definition of kernel_function_s
lbushi25 51e7aff
Merge branch 'intel:sycl' into enqueue_free_functions
lbushi25 4dc3224
Update free_function_kernels_enqueue.cpp
lbushi25 0b6a0ac
Apply requested changes
lbushi25 a7c592e
Merge branch 'enqueue_free_functions' of https://github.com/lbushi25/…
lbushi25 c65ffbc
Some more refactoring
lbushi25 5b7c7de
Apply feedback
lbushi25 356b55a
Remove dead code
lbushi25 9830ba4
Remove more dead code
lbushi25 34b0b17
Add more tests
lbushi25 d42cbdc
Merge branch 'sycl' into enqueue_free_functions
lbushi25 1acde56
Address feedback
lbushi25 07d5043
Merge branch 'enqueue_free_functions' of https://github.com/lbushi25/…
lbushi25 efd5cbf
Fix formatting
lbushi25 92671f1
Update free_function_kernels_enqueue.cpp
lbushi25 426a0b4
Fix a bug in enqueue free functions implementation
lbushi25 8121863
Merge branch 'sycl' into enqueue_free_functions
lbushi25 5cebcb7
Add test cases
lbushi25 fa157b7
Merge branch 'enqueue_free_functions' of https://github.com/lbushi25/…
lbushi25 f8899f3
Update free_function_kernels_enqueue.cpp
lbushi25 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The bug is in this line. I had forgotten to pass the
Dimensionstemplate parameter tosycl::nd_item<>and so it always defaults tosycl::nd_item<1>which makes it impossible to work with 2 or 3 dimensional kernels.